ocaml-lib-devel

[Ocaml-lib-devel] Xarray update

[Nicolas C. <war...@fr...>]

Xarray modifications :
    - added exception policy ( Invalid_arg of int * string * string )
    - added :
            val empty : 'a t -> bool
    - removed useless parenthesis in "if"
    - removed ?resizer in functions, and added :
            val set_resizer : 'a t -> resizer_t -> unit
       this makes the source code and the signatures more readable.

(should be commited when you read this mail)

Nicolas Cannasse

Re: [Ocaml-lib-devel] Xarray update

[Brian H. <bri...@ql...>]

On Sun, 11 May 2003, Nicolas Cannasse wrote:

> Xarray modifications :
>     - added exception policy ( Invalid_arg of int * string * string )
>     - added :
>             val empty : 'a t -> bool
>     - removed useless parenthesis in "if"

All the above are cool.

>     - removed ?resizer in functions, and added :
>             val set_resizer : 'a t -> resizer_t -> unit
>        this makes the source code and the signatures more readable.

I liked the ability to specify resizer functions at creation time.  
Different xarrays, used for different purposes, might need different 
reallocation routines.  If the signatures aren't the most legible, a doc 
comment should clear up the confusion.

Brian

Re: [Ocaml-lib-devel] Xarray update

[Nicolas C. <war...@fr...>]

> I liked the ability to specify resizer functions at creation time.  
> Different xarrays, used for different purposes, might need different 
> reallocation routines.  If the signatures aren't the most legible, a doc 
> comment should clear up the confusion.

I understand you, but it add to be in many functions if you want to do so.
Perhaps only for XArray.make would be enough ?

Nicolas Cannasse

Re: [Ocaml-lib-devel] Xarray update

[Brian H. <bri...@ql...>]

On Wed, 14 May 2003, Nicolas Cannasse wrote:

> > I liked the ability to specify resizer functions at creation time.  
> > Different xarrays, used for different purposes, might need different 
> > reallocation routines.  If the signatures aren't the most legible, a doc 
> > comment should clear up the confusion.
> 
> I understand you, but it add to be in many functions if you want to do so.
> Perhaps only for XArray.make would be enough ?

How about this.  We leave the resizer function off all the extant 
functions, but add three functions:

val set_resizer : resizer_t -> t -> unit
(* sets the resizer function for an xarray *)

val get_resizer : t -> resizer_t
(* gets the current resizer function for a given xarray *)

val default_resizer : resizer_t
(* the default resizer function the library is using- allowing the library
   to change default schemes later on, and making it a more memorable
   name. *)

Brian

Re: [Ocaml-lib-devel] Xarray update

[Nicolas C. <war...@fr...>]

> > I understand you, but it add to be in many functions if you want to do
so.
> > Perhaps only for XArray.make would be enough ?
>
> How about this.  We leave the resizer function off all the extant
> functions, but add three functions:
>
> val set_resizer : resizer_t -> t -> unit
> val get_resizer : t -> resizer_t
> val default_resizer : resizer_t

I added that to the CVS , renamed Xarray to DynArray , updated all the
documentation, added a Makefile and a README , and tested/corrected the
documentation generation with ocamldoc .

Nicolas Cannasse