From: Robert A. <bob...@ed...> - 2007-11-27 14:39:30
|
On Mon, 2007-11-26 at 20:51 +0200, Janne Hellsten wrote: > Hi, > > > We've found some tiny bugs in extlib-1.5: > > > > - off by one error in IO.ml for writing 16 bit integers > > - off by one error in unzip.ml in reading of uncompressed blocks > > - fix possible under-reading in unzip.ml > > > > Patch attached. > > Do you happen to have test cases for these failures? I'd like to add > test cases for these into the extlib test suite. Actually, looking at it again, I'm not sure the third one is a bug: the code that is already present handles the case of under-reading. I've attached a short ocaml program with test cases for the other two. Bob |