[Ocaml-lib-devel] [PATCH] one more fix to BitSet module

[Janne H. <ja...@hy...>]

Hopefully this is the last one for now.  This is bigger than the 
previous patch as it addresses more problems.  With these changes, 
BitSet passes all current testing suite tests.

If you guys could take a look again..?  I will commit after OK'd. 
is_set change hasn't been discussed here, but I took the liberty to make 
that change anyway.

If you want more speed, Ocamlopt should be passed -noassert in the 
Makefile to turn off assertion checks.  This should be pretty safe, 
since there doesn't seem to be much code using asserts anyway.

Summary of changes:

  - Assertion guarded bget/bset/bfill/bblit functions
  - is_set raises Negative_index if passed a negative index (Doesn't 
make much sense to pass in negative indices, right?)
  - Removed unite/intersect/differentiate/differentiate_sym 
implementations and rewrote them using union/inter/diff/sym_diff.  Might 
make just slightly slower, but I guess it's better that they don't 
overflow anymore.
  - Small optimizations to union, diff etc functions (innerloops a few 
instructions shorter)

ciao,
janne