Re: [Ocaml-lib-devel] a bug in BitSet?

[skaller <sk...@us...>]

On Fri, 2004-12-24 at 22:32, Bardur Arantsson wrote:
> On Fri, Dec 24, 2004 at 10:05:10PM +1100, skaller wrote:
> 
> > On Fri, 2004-12-24 at 11:31, Janne Hellsten wrote:
> > 
> > > Since I guess people are not willing to stop using unsafe_get/put (at 
> > > least not completely), we should think of some other way to achieve 
> > > bounds checking so that it doesn't hurt performance.
> > 
> > Why doesn't just the usual get/put and compilation with -unsafe 
> > for a production build work? I mean that's the idea of -unsafe 
> > isn't it?
> 
> Well, it probably works, but it requires even more
> confidence that the code is correct, because suddenly
> *every* array/string access becomes unsafe.

> I don't think I have that much confidence in the extlib
> code right now...

The point is that the change needs to be made
to test it .. and gain that confidence. I think you should
be able to run a version with the checks still in place
if you want.

> I think this could be implemented by using pa_macro

Yes, but I think we should avoid camlp4. This is supposed
to be a core library.

-- 
John Skaller, mailto:sk...@us...
voice: 061-2-9660-0850, 
snail: PO BOX 401 Glebe NSW 2037 Australia
Checkout the Felix programming language http://felix.sf.net