Re: [Ocaml-lib-devel] Re: Dllist ? IndexTree ?

[Nicolas C. <war...@fr...>]

> New version available here:
>     http://www.wingnet.net/~jesse/ocaml/dllist/index.html
>
> Changes:
> - merge -> splice
> - jump -> skip
> - enums reimplemented
> - added rev_enum function
>
> My sourceforge ID is 'trevarthan'. I'll be the maintainer.
>
> Thanks!

I would add an "add" function to would be an append returning "unit"
(because I don't want all the time to write ignore...). I would also
eliminate the use of a data structure for enum operations , the "valid" test
can be replaced everywhere by a curr == node , this might simplify
implementation.

For the syntax/typo :
- remove all ;; because they are not needed
- please replace your 8 chars indentation by tabs or 2/4 spaces indents

It's ok for inclusion into ExtLib, you are now developer of ExtLib and you
can commit to the CVS once ready.

Please check (that goes for Brian IdxTree too) that your module builds well
with Makefile and with install.ml script, and that the documentation
generated by ocamldoc , with install script ( and ExtLib CSS ) is consistent
with other modules.

Thanks
Nicolas Cannasse