Re: [Ocaml-lib-devel] Re: Dllist ? IndexTree ?

[Jesse G. <je...@wi...>]

On Friday 10 September 2004 5:17 pm, Nicolas Cannasse wrote:
> > New version available here:
> >     http://www.wingnet.net/~jesse/ocaml/dllist/index.html
> >
> > Changes:
> > - merge -> splice
> > - jump -> skip
> > - enums reimplemented
> > - added rev_enum function
> >
> > My sourceforge ID is 'trevarthan'. I'll be the maintainer.
> >
> > Thanks!
> 
> I would add an "add" function to would be an append returning "unit"
> (because I don't want all the time to write ignore...)

OK. Do you think something like "add_before" might be useful too?
(prepend with unit return value) I suck with function naming, so please
feel free to help me out.


> . I would also 
> eliminate the use of a data structure for enum operations , the "valid" test
> can be replaced everywhere by a curr == node , this might simplify
> implementation.

Actually, I tried this before I submitted the current implementation and I
couldn't get it to work. The problem seemed to be that Dllist has no
concept of Empty, so the length function becomes really difficult to
implement.

Brian, do you think it's possible to implement enums without the "valid"
test? If everyone thinks it's possible then I'll give it another shot. I just
didn't have much luck the first time around.


> For the syntax/typo :
> - remove all ;; because they are not needed
> - please replace your 8 chars indentation by tabs or 2/4 spaces indents

OK. I'll make these changes this weekend.

-- 
Jesse Guardiani, Systems Administrator
WingNET Internet Services,
P.O. Box 2605 // Cleveland, TN 37320-2605
423-559-LINK (v)  423-559-5145 (f)
http://www.wingnet.net