From: Richard J. <ri...@an...> - 2004-08-06 10:15:48
|
On Fri, Aug 06, 2004 at 08:05:50PM +1000, skaller wrote: > On Fri, 2004-08-06 at 19:52, Richard Jones wrote: > > On Fri, Aug 06, 2004 at 11:37:25AM +0200, Bardur Arantsson wrote: > > > > let filename = output_tempfile data in > > > > let in_chan = Unix.open_process_in ("identify " ^ filename) in > > > > > > This is very bad form: What if filename contains shell > > > metacharacters or spaces? > > > > 'output_tempfile' is guaranteed not to contain shell metacharacters or > > spaces, so it's OK. > > guarranteed by which ISO standard? I wrote output_tempfile, so guaranteed by my 'Jones' standard. Rich. -- Richard Jones. http://www.annexia.org/ http://www.j-london.com/ Merjis Ltd. http://www.merjis.com/ - improving website return on investment MAKE+ is a sane replacement for GNU autoconf/automake. One script compiles, RPMs, pkgs etc. Linux, BSD, Solaris. http://www.annexia.org/freeware/makeplus/ |