[Ocaml-lib-devel] Bug in ExtString.String.replace

[Richard J. <ri...@an...>]

let replace f s =
	let len = String.length s in
	let tlen = ref 0 in
	let rec loop i acc =
		if i = len then acc else 
			let s = f (unsafe_get s i) in
			tlen := !tlen + length s;
			loop (i-1) (s :: acc)
                             ^^^^^------------------------ should be (i+1)
	in
	let strs = loop 0 [] in
	let sbuf = create !tlen in
	let pos = ref !tlen in
	let rec loop2 = function
		| [] -> ()
		| s :: acc ->
			let len = length s in
			pos := !pos - len;
			blit s 0 sbuf !pos len;
			loop2 acc
	in
	loop2 strs;
	sbuf
-- 
Richard Jones. http://www.annexia.org/ http://www.j-london.com/
Merjis Ltd. http://www.merjis.com/ - improving website return on investment
C2LIB is a library of basic Perl/STL-like types for C. Vectors, hashes,
trees, string funcs, pool allocator: http://www.annexia.org/freeware/c2lib/