Re: [Ocaml-lib-devel] contributions

[Dustin S. <du...@sp...>]

On Dec 9, 2003, at 22:24, Nicolas Cannasse wrote:

>> val split : string -> char -> int -> string list
>> val split_chars : string -> char list -> int -> string list
>> val strstr : string -> string -> int -> int
>> val ends_with : string -> string -> bool
>> val begins_with : string -> string -> bool
>
> Are theses not already in ExtString ?
> ( you need to look the documentation into ExtString.String module on 
> the
> website, or edit the CVS version of extString.mli that might be 
> up-to-date )

	Yeah, I pasted that before looking in CVS.

> Handling strings are char or int arrays is very inefficient, and 
> Streams are
> not used in the Extlib.
> Please look at Enum modules and try to express your lists , arrays and
> streams as enums, this will make your code a lot more plugable into the
> Extlib.

	Those arrays are lookup tables.  Are you certain Enum is faster than 
char_map.(x) ?  Enum might make sense to use in place of the Streams.

	Is there a reason Streams shouldn't be used?  How about a Stream and 
Enum conversion module?

--
SPY                      My girlfriend asked me which one I like better.
pub  1024/3CAE01D5 1994/11/03 Dustin Sallings <du...@sp...>
|    Key fingerprint =  87 02 57 08 02 D0 DA D6  C8 0F 3E 65 51 98 D8 BE
L_______________________ I hope the answer won't upset her. ____________