Re: [Ocaml-lib-devel] ExtList: using _setcdr instead of Obj.magic

[Nicolas C. <war...@fr...>]

> Went through and changed all the inlined _setcdr calls to normal _setcdr
> calls.

Uh ! it took me some time to inlined them :'(

> a) If we never call the function, why define it?

It is called , it should actually be called when call - complexity is lower
than O(n) since the overhead is not big.

> b) function calls aren't that expensive.  And _setcdr is probably inlined
> in most cases anyways.

In native code, there is no problem with it.
In bytecode, the speedups are around 20% and since we're working an on
Standard library, it would be good to provide efficient code to the
community, don't you think ? That's why after lots of benchs and differents
versions I ended up inlining the calls.

> c) In the future, when we have to change the magic incantation to make it
> work, we only have to change it once, in _setcdr, and not all over.

We will never have to do so.
And if we do, I volunteer to make the changes.

Nicolas Cannasse