Re: [Ocaml-lib-devel] Ocaml indent?

[Brian H. <bri...@ql...>]

On Mon, 24 Feb 2003, Blair Zajac wrote:

> Brian Hurt wrote:
> I think in general this is a bad idea.  I would not want my code reindented
> upon commit.

I'm not that religous about indenting :-).  And I've dealt with formatting 
diasters- including one file that had been editted by three different 
people, in three different editors, using both unix and windows style 
tabbing, different indent levels, and different tab stops.  Which made me 
appreciate enforced standard indenting.

> 
> Also, this seems to mix style with real coding changes.  Many times, I
> perform two separate commits to make code reviews easier, one for
> coding changes, and one for style changes.
> 

Yep.  Nothing is more horrifying than seeing a log message that reads 
"fixed indenting, and a couple of bugs".  Because you know that the 
reindenting touched almost every single line of code, making diffs nigh on 
to impossible, and hiding what the real changes are.  Been there, done 
that too.

Brian