From: Blair Z. <bl...@or...> - 2003-02-24 20:13:13
|
Brian Hurt wrote: > > Something just occurred to me. CVS has the ability to run a script on > commits- explicitly, this is so you can run indent on code being > committed. For those who don't know, indent is a program which > (re-)indents C code. Allowing you to enforce convention like "no tabs", > "curly braces on their own lines", etc. > > If something like this existed for Ocaml, we could use to force indenting > rules (once they are settled on). I think in general this is a bad idea. I would not want my code reindented upon commit. If there are commits that have poor coding style, then those could be pointed out by the other developers and fixed in subsequent commits. Also, this seems to mix style with real coding changes. Many times, I perform two separate commits to make code reviews easier, one for coding changes, and one for style changes. Best, Blair -- Blair Zajac <bl...@or...> Plots of your system's performance - http://www.orcaware.com/orca/ |