Re: [Ocaml-lib-devel] Making extlib compile under -safe-string

[ygrek <yg...@au...>]

On Sun, 28 Sep 2014 23:21:10 +0200
Gabriel Scherer <gab...@gm...> wrote:

> Dear all,
> 
> Attached is a patch that enables compilation of Extlib under -safe-string
> (the new OCaml 4.02.0 option that makes string immutable and creates a
> distinct type "bytes" of mutable sequences of bytes).
> This is a relatively invasive change:
> - a dependency on the Bytes compatibility package of recent ocamlfind
> versions (>=1.5.3) is introduced
> - a fair number of interface functions have argument or return type that
> changed from "string" to "Bytes.t"
> - IO.{nwrite,nread} have been duplicated to manipulate either string or
> byte sequences
> - a new extBuffer is added, that conditionally backports bytes-related
> Buffer function

Considering that extlib has a build mode that doesn't require ocamlfind and I believe
there are users relying on it, so we will need to provide a solution for this usecase too..
Maybe doing Std.Bytes = String will be enough.
FTR the new repo is at https://github.com/ygrek/ocaml-extlib
Thanks for the patch

--