From: Amit D. <ad...@du...> - 2008-05-19 09:53:56
|
Hi, I think the original idea behind ExtLib is that functions are either highly used and small or fairly commonly used and complicated. I think some people were using it for embedded applications, and are worried about code bloat. get_exn is fairly simple, and as Option.get already returns the fairly general Not_found exception, my impression is that it won't be highly used. That said, there are cases where a new function with a different exception might be handy. E.g. Invalid_argument in array's returning the index number which caused the problem... -Amit On Mon, May 19, 2008 at 10:43 AM, Richard Jones <ri...@an...> wrote: > On Sun, May 18, 2008 at 11:28:08PM +0300, Janne Hellsten wrote: >> What kind of example uses did you have in mind for the Option additions? >> >> Not sure if I agree that get_exn is too useful an addition. > > I disagree: I think that as long as additional functions maintain a > consistent style with the rest of the library, are working, documented > and useful to someone, and don't consume any more "module namespace", > then there shouldn't be any barrier to adding them. > > In this case I have no problem with David's additional functions, the > patches are fine[1], and I would be inclined to add them. > > Rich. > > [1] David: please always post unified diffs as in your second email, > not tarballs as in the first. > > -- > Richard Jones > Red Hat > > ------------------------------------------------------------------------- > This SF.net email is sponsored by: Microsoft > Defy all challenges. Microsoft(R) Visual Studio 2008. > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ > _______________________________________________ > ocaml-lib-devel mailing list > oca...@li... > https://lists.sourceforge.net/lists/listinfo/ocaml-lib-devel > |