Menu

#97 error handling for bosh.initSettings is flawed

Current
closed
nobody
Other (45)
5
2014-12-27
2011-08-03
Myk Taylor
No

error handling for bosh.initSettings attempts to offer recovery options if BashSettings.dat and/or BashSettings.dat.bak cannot be read, but it suffers from a few deficiencies:
1) if a problem is detected, it attempts to show a messagebox, but wx.App has not been initialized by that point and the call fails
2) it does not catch ValueErrors, which are the errors actually thrown when there is a format mismatch
3) it does not do similar recovery actions for Table.dat/Table.dat.bak, meaning that even if BashSettings.dat is deleted, the program still would not start due to Table.dat being in the wrong format

Discussion

  • Myk Taylor

    Myk Taylor - 2011-08-03

    ValueError will likely no longer be thrown due to r1513, but the other problems still apply

     
  • Myk Taylor

    Myk Taylor - 2011-08-30

    To solve the first point, I think we need to refactor our initialization:
    1) move module-level functional calls into classes or into main() so we can't fail before we enter main
    2) initialize wx before anything else
    3) display all startup errors graphically

     
  • Mr_and_Mrs_D

    Mr_and_Mrs_D - 2014-12-27
    • status: open --> closed
    • Group: --> Current
     

Log in to post a comment.

MongoDB Logo MongoDB