Re: [OJB-developers] PersistentFieldDefaultImpl NPE
Brought to you by:
thma
From: Jakob B. <jbr...@ho...> - 2002-06-07 16:06:17
|
hi leandro, i successfully ran the tests with the current version from cvs (not 0.9): junit: [junit] Running test.ojb.broker.AllTests [junit] [BOOT] INFO: OJB.properties: file:/D:/Java/eclipse_0602/workspace/ojb-1-0/target/test/ojb/OJB.properties [junit] [BOOT] INFO: loading XML took 831 msecs [junit] [DEFAULT] WARN: Please define a public constructor for class test.ojb.broker.ArticleWithReferenceProxy [junit] with the following signature: (int, java.lang.String, int, int, java.lang.String, double, int, int, int, boolean). [junit] It must initialize the classes persistent attributes. This is recommended to increase performance but it's not mandatory! [junit] Tests run: 68, Failures: 0, Errors: 0, Time elapsed: 8.642 sec [junit] Running test.ojb.odmg.AllTests [junit] [BOOT] INFO: OJB.properties: file:/D:/Java/eclipse_0602/workspace/ojb-1-0/target/test/ojb/OJB.properties [junit] [BOOT] INFO: loading XML took 861 msecs [junit] Tests run: 95, Failures: 0, Errors: 0, Time elapsed: 9.323 sec [junit] Running test.ojb.soda.AllTests [junit] [BOOT] INFO: OJB.properties: file:/D:/Java/eclipse_0602/workspace/ojb-1-0/target/test/ojb/OJB.properties [junit] [BOOT] INFO: loading XML took 892 msecs [junit] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 5.638 sec i do also have no problems running build junit out of the box of rel-0.9: junit: [junit] Running test.ojb.broker.AllTests [junit] [BOOT] INFO: OJB.properties: file:/D:/Java/Db/ojb-0.9/target/test/ojb/OJB.properties [junit] [BOOT] INFO: loading XML took 821 msecs [junit] Tests run: 66, Failures: 0, Errors: 0, Time elapsed: 6.148 sec [junit] Running test.ojb.odmg.AllTests [junit] [BOOT] INFO: OJB.properties: file:/D:/Java/Db/ojb-0.9/target/test/ojb/OJB.properties [junit] [BOOT] INFO: loading XML took 942 msecs [junit] Tests run: 95, Failures: 0, Errors: 0, Time elapsed: 9.313 sec [junit] Running test.ojb.soda.AllTests [junit] [BOOT] INFO: OJB.properties: file:/D:/Java/Db/ojb-0.9/target/test/ojb/OJB.properties [junit] [BOOT] INFO: loading XML took 861 msecs [junit] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 5.438 sec jakob ----- Original Message ----- From: "Leandro Rodrigo Saad Cruz" <le...@ib...> To: "Jakob Braeuchi" <jbr...@ho...> Cc: <obj...@li...> Sent: Friday, June 07, 2002 4:58 PM Subject: Re: [OJB-developers] PersistentFieldDefaultImpl NPE > Jakob. I checked rel-0-9 out and ran the tests, They failed (see > attachement) and they don't have any changes of mine which were part of > my last commit on his files. > o.b.s.PersistenseBrokerImpl > o.b.m.PersistentField > o.b.m.PersistentFieldDefaltImpl > o.b.m.PersistentFieldPropertyImpl. > > I'm assuming that this tests are broken as of rel-0-9 and we should fix > them in order to push other changes/bugfixes to the cvs repo ! > > Does anyone can point out if this tests were broken ? > Is anyone running the tests on a daily basis ? > > On Fri, 2002-06-07 at 11:05, Jakob Braeuchi wrote: > > hi leandro, > > > > yes that's the problem, you need to comment the logger line. > > yesterday i only loaded your fixes and the tests failed because of this > > logger-line ??? > > > > jakob > > > > ----- Original Message ----- > > From: "Leandro Rodrigo Saad Cruz" <le...@ib...> > > To: "Jakob Braeuchi" <jbr...@ho...> > > Cc: <obj...@li...> > > Sent: Friday, June 07, 2002 3:48 PM > > Subject: Re: [OJB-developers] PersistentFieldDefaultImpl NPE > > > > > > > I checked rel-0-9 and run the tests ! > > > They are failing too ! I dunno what was the state of this tests before > > > rel-0-9 > > > > > > On Fri, 2002-06-07 at 10:30, Jakob Braeuchi wrote: > > > > hi leandro, > > > > > > > > with the current state of the test objects i prefer to comment this > > line. > > > > afaik it was no problem before your changes, but i do not know the > > reason it > > > > fails now. > > > > > > > > jakob > > > > > > > > ----- Original Message ----- > > > > From: "Leandro Rodrigo Saad Cruz" <le...@ib...> > > > > To: "Jakob Braeuchi" <jbr...@ho...> > > > > Cc: <obj...@li...> > > > > Sent: Thursday, June 06, 2002 11:10 PM > > > > Subject: Re: [OJB-developers] PersistentFieldDefaultImpl NPE > > > > > > > > > > > > > Hi. I believe I was the last one to change this file. > > > > > When I commited this changes the ant target junit was failing due to > > > > > SQLExceptions. I can comment this line if you want. > > > > > > > > > > My opinion is that every testcase should be ok at all times ! > > > > > Can we work on that ? > > > > > > > > > > On Thu, 2002-06-06 at 17:51, Jakob Braeuchi wrote: > > > > > > hi , > > > > > > > > > > > > i just loaded the newest version of PersistentFieldDefaultImpl and > > now i > > > > get > > > > > > NPE caused by the statement > > > > > > > > > > > > logger.debug("Setting field:"+f.getName()+" in obj:"+obj+" > > > > value:"+value); > > > > > > > > > > > > in method set(obj, value). the npe is mainly caused by the > > toString() > > > > > > implementation of obj. > > > > > > ie. obj is a ProductGroupWithCollectionProxy and toString() fails > > bcause > > > > > > allArticlesInGroup() is null. > > > > > > the point is that we just try to set allArticlesInGroup for > > > > > > ProductGroupWithCollectionProxy in PersistenFieldDefaultImpl . > > > > > > > > > > > > the simplest fix is to comment the logger call. but it may be > > cleaner to > > > > fix > > > > > > the various toString() in the test objects. > > > > > > > > > > > > jakob > > > > > > > > > > > > _______________________________________________________________ > > > > > > > > > > > > Don't miss the 2002 Sprint PCS Application Developer's Conference > > > > > > August 25-28 in Las Vegas -- > > http://devcon.sprintpcs.com/adp/index.cfm > > > > > > > > > > > > _______________________________________________ > > > > > > Objectbridge-developers mailing list > > > > > > Obj...@li... > > > > > > https://lists.sourceforge.net/lists/listinfo/objectbridge-developers > > > > > -- > > > > > Leandro Rodrigo Saad Cruz > > > > > IT - Inter Business Tecnologia e Servicos (IB) > > > > > http://www.ibnetwork.com.br > > > > > > > > > > > > > _______________________________________________________________ > > > > > > > > Don't miss the 2002 Sprint PCS Application Developer's Conference > > > > August 25-28 in Las Vegas -- http://devcon.sprintpcs.com/adp/index.cfm > > > > > > > > _______________________________________________ > > > > Objectbridge-developers mailing list > > > > Obj...@li... > > > > https://lists.sourceforge.net/lists/listinfo/objectbridge-developers > > > -- > > > Leandro Rodrigo Saad Cruz > > > IT - Inter Business Tecnologia e Servicos (IB) > > > http://www.ibnetwork.com.br > > > > > > > -- > Leandro Rodrigo Saad Cruz > IT - Inter Business Tecnologia e Servicos (IB) > http://www.ibnetwork.com.br > |