[OJB-developers] The new ContentHandler stuff in o.b.metadata
Brought to you by:
thma
From: Thomas M. <tho...@ho...> - 2002-05-19 12:58:29
|
Hi Chris, I had a look at your new ContentHandler stuf. I like it, as it has a much better design as than my old monolithic XmlRepositoryHandler with its giant switch statement. I'm currently restructuring the repository.dtd. To reduce my work I won't touch your ContentHandler stuff in this iteration. Thus we will have to patch it after all my changes are checked in. I see the following issues: - The ContentHandler classes don't use the Classes RepositoryElements and RepositoryTags that define all syntactic tokens used by the OJB repository.dtd but use their own declarations. This should be changed. - No comments and licence statements yet. must me added. - The code has some uncritical references to classes (com.demandsolutions.*) not part of OJB. these should be removed. I think the best think is to wait until my current iteration on the repository.dtd is finished. I will inform you when I'm done. cheers, Thomas |