[OJB-developers] various questions

[<Joa...@tp...>]

Hy,

I'm once again digging deeper into OJB, so I'll be back for some more
questions, please be patient. Some of them are very small and may sound
like nit-picking, but i'm just interested.

1.) most parameters that are ClassDescription objects are named "mif". Why?

2.) some classes use an "m_" prefix for member variables, others don't. Is
there an "official" way? Personally I'd vote against them.

3.) often there are constructs like "Identity oid = new Identity(obj);",
where oid is never used. IDEA marks them with a warning, so I usually
remove the variable (I can't remove the calls to new Identity(), 'though).
I think a better solution would be to move the logic away from the
constructor and move it into a factory/getter-method (this would have the
advantage that in the case of a VirtualProxy you could return the same
Identity object). A "Identity.getIdentity(obj);" without assignment feels
better to me, than a "new Identity(obj);" all alone.

4.) Sometimes while browsing I find files with broken JavaDoc (mostly "
@something a parameter" instead of "@param something a parameter" and wrong
parameter names). IDEA shows them as errors (it has an option to show them
as warnings, but I prefer keeping clean javadoc). Is it a OK when I commit
files where I only change the javadoc (I can't complete missing JavaDoc
most of the times, 'cause I don't know enough, yet).

5.) Same is true for unused imports/functions/member variables. For example
getCollectionFromQuery(Class,Query) in PersistenceBrokerImpl is never used.

6.) is it correct that the new build process doesn't use the build
directory anymore? if this is true, could we remove the build directory
from cvs?

regards & thanks in advance
Joachim Sauer