Re: [OJB-developers] superflous CriteriaException

[Thomas M. <tho...@ho...>]

Hi Rainer,

> "Bischof, Rainer" wrote:
> 
> Hi Thomas,
> 
> I found a superflous Exception ojb.broker.query.CriteriaException
> 
> It is only declared to be thrown by Criteria.addOrCriteria() but it is
> never thrown at all. Should be removed, I guess.
> This leads to some simple modifications in DListImpl, DSetImpl and
> OJBSearchFilter. Please find attached all affected sources.
> 

Thanks, I will remove it!

> BTW:
> I keep running into traps where Exceptions are silently ignored. I
> guess this should change but that would lead to lots of API changes as
> methods have to declare Exceptions that they haven't thrown before.
> This would also lead to lots of small modifications to many classes,
> so I guess this can only be done by you as it will be too much work to
> integrate many small changes into your concurrently changing codebase.
> Or we need a code-freeze for some time after the next release so that
> a volunteer can do it.
> 
> What do you think?
> 

This cleanup is already on the todo list. I will try to it without
changes to the PersistenceBroker API. 
I agree that it will be easier to do this myself than to delegate it and
to reintegrate the results...

So, I just need some spare time...

If there are urgent things that are not working, I can provide you with
quick bug fixes.

Thomas

> Rainer Bischof
> EDS - Electronic Data Systems
> European Automotive Solution Center - Distributed Solutions
> Email: rai...@ed...
> 
>                     Name: Criteria.java
>    Criteria.java    Type: unspecified type (application/octet-stream)
>                 Encoding: quoted-printable
> 
>                            Name: OJBSearchFilter.java
>    OJBSearchFilter.java    Type: unspecified type
>                                  (application/octet-stream)
>                        Encoding: quoted-printable
> 
>                     Name: DSetImpl.java
>    DSetImpl.java    Type: unspecified type (application/octet-stream)
>                 Encoding: quoted-printable
> 
>                      Name: DListImpl.java
>    DListImpl.java    Type: unspecified type
>                            (application/octet-stream)
>                  Encoding: quoted-printable