Re: [Nvrec-devel] NuppelVideo improvements

[Antonio B. M. <ant...@li...>]

El jue, 13-09-2007 a las 20:55 +0200, Ralf Hoffmann escribió:
> Hi,
> 
> On 2007-09-13 16:44, Antonio Beamud Montero wrote:
> > Yes, I'm still maintaining it. 
> > Your patches are welcome.
> 
> Great to hear. I attached two patches. The first one slightly changes 
> the cpu test, fixes a small problem with a NULL pointer and it changes 
> to status line to use fixed fields.

Ok.

> The actual improvement is in the second patch. It adds a simple write 
> thread to the nuppelvideo core. I experienced some frame drops once in a 
> while (every 1-5 minutes) although my system should be fast enough 
> (Athlon X2 2GHz). I looked into it and found out that for whatever 
> reason a write operation in the nuvfile_core takes up to half a second. 
> Since there are only 6 buffers available with my saa7134 based tv card 
> it will drop some frames. Now all write operations are done by the write 
> thread so it won't stop the main thread. It does so by copying every 
> buffer which might be a problem on slow systems. There's a define which 
> restores the old behaviour if this is a performance problem.
> 
> I could add a configure option to explicitly enable the write thread if 
> you think this is a better way.

For now, it's enough with the define directive. 

I've submitted this two patches, but i've problems to compile the
source. Can be problems with my distro (Ubuntu 6.10).. I'll test it
later.

Can you check it out and try it...?

Greetings.