#18 Philips 7108 and 0.4.5 = null chip?

[Anonymous]

It seems after upgrading to 0.4.5 nvtv suddenly doesn't
know that I have a TV chip, a simple nvtv -P will give
me this:

NVTV 0.4.5 Probe
GeForce4 Ti 4200 (01:00.00) (0253) io=0xEE000000
Null chip: create
MC_boot=025300A3 FB_boot=00000000 FB_conf=000F0003
EXT_boot=98C471AF
PCRTC 1/2:
Assoc = 00001310 Config = 00000002
PRAMDAC 1/2:
PLL coeff = 30000700 0x524 = 00000000 VPLL
= 00034D04 / 00034D04
Gen Ctrl = 20100130 Test Ctrl = F0000000 TV Setup
= 00000000
FP Test = 00000000 TG Ctrl = 21000022 FP Debug
= 31101111
TV blank = v= 00000000-00000000 h=
00000000-00000000 40000000
TV slave = v= 00000000-00000000 h=
00000000-00000000 00000000,00000000
TV slave' = 00000000
PCRTC 2/2:
Assoc = 00000000 Config = 00000000
PRAMDAC 2/2:
PLL coeff = 00000000 0x524 = 00000000 VPLL
= 000667FB / 0004AE64
Gen Ctrl = 00101100 Test Ctrl = 00000000 TV Setup
= 00000001
FP Test = 00000000 TG Ctrl = 11000011 FP Debug
= 21101111
TV blank = v= 00000000-00000000 h=
00000000-00000000 40000000
TV slave = v= 00000000-00000000 h=
00000000-00000000 00000000,00000000
TV slave' = 00000000
CRT registers 1/2:
00: A3 7F 7F 87 84 95 24 F5 00 60 00 00 00 00 6D 20
10: 02 88 FF 00 00 FF 25 E3 FF 40 3C 13 3C 00 00 03
20: AC FE F7 A3 00 00 20 A3 03 00 00 00 00 00 00 07
30: FA E1 00 00 02 13 3E 31 00 FF 72 22 B8 00 3E 31
40: 00 00 00 01 00 80 00 01 00 74 00 01 20 12 66 00
50: 1E 31 14 40 00 40 00 00 80 00 00 00 00 22 22 00
60: A3 7F 7F A7 A0 A1 00 01 24 03 FF 02 21 03 21 03
70: 25 22 FF FF FF FF FF FF FF FF FF FF FF FF FF FF
80: FF FF FF FF 00 00 00 00 00 00 00 00 00 00 00 00
90: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
CRT registers 2/2:
00: A3 7F 7F 87 84 95 24 F5 00 60 00 00 00 00 6D 20
10: 03 80 FF 00 00 FF 25 E3 FF 20 3C 03 1C 00 00 03
20: 80 FA F7 A3 80 00 20 A3 02 00 00 00 00 00 00 00
30: 00 00 00 00 02 02 13 30 00 FF 00 00 00 00 10 31
40: 00 00 00 01 00 00 00 01 00 00 00 00 10 22 22 00
50: 13 31 10 00 00 40 00 00 7F 10 00 00 00 22 22 00
60: A3 7F 7F A7 A0 A1 00 01 24 03 FF 02 21 03 21 03
70: 25 22 FF FF FF FF FF FF FF FF FF FF FF FF FF FF
80: FF FF FF FF 00 00 00 00 00 00 00 00 00 00 00 00
90: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
ATTR registers 1/2:
00: 00 01 02 03 04 05 06 07 08 09 0A 0B 0C 0D 0E 0F
10: 01 00 0F 00 00 05 0F 07 09 09 0F 0B 0C 0D 0F 0F
ATTR registers 2/2:
00: 00 01 02 03 04 05 06 07 08 09 0A 0B 0C 0D 0E 0F
10: 01 00 0F 00 00 05 0F 07 09 09 0F 0B 0C 0D 0F 0F
SEQ registers 1/2:
00: 03 01 0F 00 0E 00 00 00 03 01 0F 00 0E 00 00 00
GR registers 1/2:
00: 00 00 00 00 00 40 05 0F FF 00 00 00 00 00 00 00
MISC registers 1/2:
input0=70 vse=01 feat=00 misc=EB
SEQ registers 2/2:
00: 03 01 0F 00 0E 00 00 00 03 01 0F 00 0E 00 00 00
GR registers 2/2:
00: 00 00 00 00 00 40 05 0F FF 00 00 00 00 00 00 00
MISC registers 2/2:
input0=70 vse=01 feat=00 misc=EB

I2C Devices: 2:42 2:88

Device 2:88 = Unknown chip (2:88)

-------------------------------------------------

Note the 'unknown chip'
Just to confirm what chip I do have I did the following

xylo log # grep Phil XFree86.0.log
(--) NVIDIA(0): Detected TV Encoder: Philips 7108

I didn't seem to have problems with 0.4.4 as it
detected my chip and used it fine (I had been using it
for at least a month with no problems).

Is there something I should have setup? Is there
something else I need to configure?

Any help would be greatly appreciated.

[Nobody/Anonymous]

Logged In: NO

I took a little look at the code, and it appears that I have
found the root of the problem.

in the file tv_common.c in the TVCreateChain function when
it sets up the chip type, after the chip type is returned
there's the switch statement switch (chip & TV_ENCODER) {

problem is TV_ENCODER is specified as 0xff00, meaning this
gives the exact same result as switch (chip) <-- this was
the code from 0.4.4

as a result this would never trigger on case
TV_PHILIPS_MODEL1: or case TV_PHILIPS_MODEL2:

I simply replaced this with what was in 0.4.4 which was case
TV_PHILIPS:

Now it appears to work fine.
Just a heads up to anyone who might be having the same problem.

:)