nunitasp-devl

[NUnitAsp-devl] SgmlParser closes Console.Error

[Igor K. <ig...@we...>]

Hello,

I'm using NUnitAsp in combination with CruiseControl.NET. From the moment I
request an aspx page with errors after I already requested such one,
NUnitAsp throws an error. I checked the NUnitAsp source code, and it seems
that SgmlReader closes the log stream that is assigned to it
(NUnitAsp/Sgml/SgmlReader.cs,line:1273).

It appears to me that this should be the callers responsibility, e.g.
NUnitAsp/WebPage.cs,line:92. In this case for instance (which is the only
case applicable to this bug), the Console.Error is passed. I don't know much
about cc.net's internals, but I suspect Console.Error is a file. So, once a
close is issued, the file becomes inaccessible. The SgmlReader still tries
to write errors to the log, but fails with a "Cannot write to a closed
TextWriter".

I "fixed" this by checking whether SgmlReader._log == Console.Error, but I
suspect that the Close has to disappear alltogether.

Igor

Re: [NUnitAsp-devl] SgmlParser closes Console.Error

[Jim S. <js...@ti...>]

Thanks for your detailed analysis, Igor.  Could you go into more detail 
about what you do to cause the exception to be thrown?  What do you mean 
by "an aspx page with errors?"  Is it possible to reproduce the problem 
without using CC.NET?

Thanks,
Jim

Igor Kalders wrote:

>Hello,
>
>I'm using NUnitAsp in combination with CruiseControl.NET. From the moment I
>request an aspx page with errors after I already requested such one,
>NUnitAsp throws an error. I checked the NUnitAsp source code, and it seems
>that SgmlReader closes the log stream that is assigned to it
>(NUnitAsp/Sgml/SgmlReader.cs,line:1273).
>
>It appears to me that this should be the callers responsibility, e.g.
>NUnitAsp/WebPage.cs,line:92. In this case for instance (which is the only
>case applicable to this bug), the Console.Error is passed. I don't know much
>about cc.net's internals, but I suspect Console.Error is a file. So, once a
>close is issued, the file becomes inaccessible. The SgmlReader still tries
>to write errors to the log, but fails with a "Cannot write to a closed
>TextWriter".
>
>I "fixed" this by checking whether SgmlReader._log == Console.Error, but I
>suspect that the Close has to disappear alltogether.
>
>Igor
>
>
>
>
>-------------------------------------------------------
>This SF.Net email is sponsored by:
>Sybase ASE Linux Express Edition - download now for FREE
>LinuxWorld Reader's Choice Award Winner for best database on Linux.
>http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click
>_______________________________________________
>NUnitAsp-devl mailing list
>NUn...@li...
>https://lists.sourceforge.net/lists/listinfo/nunitasp-devl
>  
>


-- 
Jim Shore
Titanium I.T. LLC - Making IT Profitable
Now available to help your Portland, Ore. team.

phone: 503-267-5490
email: js...@ti...

Re: [NUnitAsp-devl] SgmlParser closes Console.Error

[Igor K. <ig...@we...>]

Ok, i totally screwed up and posted this twice in the wrong way. In order to
allow a correct threading for list readers, I repost hereby with, I hope,
correct To- and Subject-field. So here's my original:
------

I'm sorry. I totally overlooked your reply (though I was monitoring the
list). So here's a (somewhat late) response. I haven't checked the source of
the new (2.2) checkin, as I haven't got the time. If the issue has been
fixed, feel free to ignore this mail ;)

> Thanks for your detailed analysis, Igor.  Could you go into more detail
> about what you do to cause the exception to be thrown?
> What do you mean by "an aspx page with errors?"

Just perform an operation that throws an exception, for instance, access an
array outside it's boundaries. So an "aspx with errors" is just an aspx that
throws an uncaught exception.

> Is it possible to reproduce the problem
> without using CC.NET?

I use TestDriven on the very same code in VS.NET, and the issue didn't arise
here. Maybe because TestDriven doesn't use a file?

Igor