numpy-discussion

[Numpy-discussion] Cannot build numpy svn on Windows

[Thomas H. <th...@py...>]

Building numpy from svn on Windows with Python 2.4.3 fails:

c:\svn\numpy\numpy\core\include\numpy\arrayobject.h(986) : fatal error C1017: invalid integer constant expression

When I change this line in the generated config.h file:

#define NPY_ALLOW_THREADS WITH_THREAD

to this one:

#define NPY_ALLOW_THREADS 1

then I can build.

Thomas

Re: [Numpy-discussion] Cannot build numpy svn on Windows

[Keith G. <kwg...@gm...>]

On 7/18/06, Thomas Heller <th...@py...> wrote:

> When I change this line in the generated config.h file:
>
> #define NPY_ALLOW_THREADS WITH_THREAD
>
> to this one:
>
> #define NPY_ALLOW_THREADS 1
>
> then I can build.

What part of numpy is threaded?

Re: [Numpy-discussion] Cannot build numpy svn on Windows

[Albert S. <fu...@gm...>]

Hello all

> -----Original Message-----
> From: num...@li... [mailto:numpy-
> dis...@li...] On Behalf Of Keith Goodman
> Sent: 18 July 2006 15:55
> To: Thomas Heller
> Cc: num...@li...
> Subject: Re: [Numpy-discussion] Cannot build numpy svn on Windows
> 
> On 7/18/06, Thomas Heller <th...@py...> wrote:
> 
> > When I change this line in the generated config.h file:
> >
> > #define NPY_ALLOW_THREADS WITH_THREAD
> >
> > to this one:
> >
> > #define NPY_ALLOW_THREADS 1
> >
> > then I can build.

This might be due to some changes Travis made.

http://projects.scipy.org/scipy/numpy/changeset/2833

I was able to build r2834 on Windows without problems. Are you still seeing
this error?

> What part of numpy is threaded?

This thread stuff is so that NumPy releases/doesn't release the GIL in
certain places.

Regards,

Albert

Re: [Numpy-discussion] Cannot build numpy svn on Windows

[Thomas H. <th...@py...>]

Albert Strasheim schrieb:
> Hello all
> 
>> -----Original Message-----
>> From: num...@li... [mailto:numpy-
>> dis...@li...] On Behalf Of Keith Goodman
>> Sent: 18 July 2006 15:55
>> To: Thomas Heller
>> Cc: num...@li...
>> Subject: Re: [Numpy-discussion] Cannot build numpy svn on Windows
>> 
>> On 7/18/06, Thomas Heller <th...@py...> wrote:
>> 
>> > When I change this line in the generated config.h file:
>> >
>> > #define NPY_ALLOW_THREADS WITH_THREAD
>> >
>> > to this one:
>> >
>> > #define NPY_ALLOW_THREADS 1
>> >
>> > then I can build.
> 
> This might be due to some changes Travis made.
> 
> http://projects.scipy.org/scipy/numpy/changeset/2833
> 
> I was able to build r2834 on Windows without problems. Are you still seeing
> this error?

No, I can build now.  Travis fixed it immediately, probably with
the change that you refer to above.

Thomas