Menu ▾ ▴

#92 list -func=TYPE not working correctly

v1.0.x
fixed
Erik Hänel
None
v1.0.9
Bug Fix
2016-08-20
2016-08-19
Erik Hänel
No

The functionality list -func=TYPE not working correctly. For example, list -func=random does not show any results.

Analysis:
In the following lines

if (sPrefix.find('[') != string::npos)
{
    sPrefix.erase(sPrefix.find('['));
    sType = sMessageScheme.substr(sMessageScheme.find('[')+1, sMessageScheme.find(']')-sMessageScheme.find(']')-1);
}
else if (sMessageScheme.find('[') != string::npos)
    sType = sMessageScheme.substr(sMessageScheme.find('[')+1, sMessageScheme.find(']')-sMessageScheme.find(']')-1);

the last char should be a '[' and not a ']'.

Implementation:
Fix was implemented as proposed by the analysis.

Tests:
list -func=TYPE now works correctly.

Discussion

  • Erik Hänel

    Erik Hänel - 2016-08-20
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2016-08-20
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,7 @@
 The functionality `list -func=TYPE` not working correctly. For example, `list -func=random` does not show any results.
+
+**Analysis:**
+
+**Implementation:**
+
+**Tests:**
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2016-08-20
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,6 +1,17 @@
 The functionality `list -func=TYPE` not working correctly. For example, `list -func=random` does not show any results.

 **Analysis:**
+In the following lines
+~~~C
+if (sPrefix.find('[') != string::npos)
+{

+    sPrefix.erase(sPrefix.find('['));
+    sType = sMessageScheme.substr(sMessageScheme.find('[')+1, sMessageScheme.find(']')-sMessageScheme.find(']')-1);
+}
+else if (sMessageScheme.find('[') != string::npos)
+    sType = sMessageScheme.substr(sMessageScheme.find('[')+1, sMessageScheme.find(']')-sMessageScheme.find(']')-1);
+~~~
+the last char should be a `'['` and not a `']'`.

 **Implementation:**
     

  • Erik Hänel

    Erik Hänel - 2016-08-20
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2016-08-20
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -14,5 +14,6 @@
 the last char should be a `'['` and not a `']'`.

 **Implementation:**
+Fix was implemented as proposed by the analysis.

 **Tests:**
    • status: implementing --> testing
     

  • Erik Hänel

    Erik Hänel - 2016-08-20
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -17,3 +17,4 @@
 Fix was implemented as proposed by the analysis.

 **Tests:**
+`list -func=TYPE` now works correctly.
    • status: testing --> fixed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB