Menu ▾ ▴

#728 More possibilities for NaN in data

v1.1.x
closed
Erik Hänel
internal (109) datamanagement (17)
v1.1.5
Change Request
2023-02-17
2022-08-30
Erik Hänel
No

NumeRe shall also support NA and N/A as replacements for NAN while loading data files.

Analysis:

This requires changes in isConvertible() and StrToCmplx() as well as in some detection algorithms in file.cpp.

Implementation:

  • Implementation: Implemented as indicated by the analysis.
  • Revision: [r1228]
  • Implementation test: A text file-based data table with multiple combinations of n/a was read successfully.

Documentation:

  • [x] ChangesLog updated
  • [x] Code changes commented
  • Documentation articles:
    • [x] corresponding documentation articles updated
    • [ ] new documentation articles created
    • [ ] not needed
  • Language files:
    • [ ] corresponding language files updated
    • [x] not needed

Tests:

File was added to the automatic SW tests. Remaining deviation was resolved within [#1334].

Related

Commit: [r1228]

Discussion

  • Erik Hänel

    Erik Hänel - 2022-09-21
    • labels: --> internal, datamanagement
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2022-09-21
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,23 @@
 NumeRe shall also support `NA` and `N/A` as replacements for `NAN` while loading data files.
+
+###Analysis:
+(*Describe, what's the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you've changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+
+###Documentation:
+* [ ] ChangesLog updated
+* [ ] Code changes commented
+* **Documentation articles:**

+    * [ ] corresponding documentation articles updated
+    * [ ] new documentation articles created
+    * [ ] not needed
+* **Language files:**
+    * [ ] corresponding language files updated
+    * [ ] not needed
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2022-10-09
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,7 +1,7 @@
 NumeRe shall also support `NA` and `N/A` as replacements for `NAN` while loading data files.

 ###Analysis:
-(*Describe, what's the issue and which changes have to be made*)
+This requires changes in `isConvertible()` and `StrToCmplx()` as well as in some detection algorithms in `file.cpp`.

 ###Implementation:

 * Implementation: (*Describe, what you've changed*)
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2022-10-09
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -4,20 +4,20 @@
 This requires changes in `isConvertible()` and `StrToCmplx()` as well as in some detection algorithms in `file.cpp`.

 ###Implementation:
-* Implementation: (*Describe, what you've changed*) 
-* Revision: [rXXX]
-* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+* Implementation: Implemented as indicated by the analysis.
+* Revision: [r1228]
+* Implementation test: A text file-based data table with multiple combinations of `n/a` was read successfully.

 ###Documentation:
-* [ ] ChangesLog updated
-* [ ] Code changes commented
+* [x] ChangesLog updated
+* [x] Code changes commented

 * **Documentation articles:**
-    * [ ] corresponding documentation articles updated
+    * [x] corresponding documentation articles updated
     * [ ] new documentation articles created
     * [ ] not needed
 * **Language files:**
     * [ ] corresponding language files updated
-    * [ ] not needed
+    * [x] not needed

 ###Tests:
 (*Describe, which tests you performed and their outcome*)
    • status: implementing --> testing
     

    Related

    Commit: [r1228]

  • Erik Hänel

    Erik Hänel - 2023-02-17
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -20,4 +20,4 @@

     * [x] not needed

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+File was added to the automatic SW tests. Remaining deviation was resolved within [#1334].
    • status: testing --> closed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB