Menu ▾ ▴

#713 Control flow headers should accept interrupts

v1.1.x
closed
Erik Hänel
ctrlflow (4) internal (109) debugger (3)
v1.1.4
Change Request
2022-08-05
2022-06-17
Erik Hänel
No

Control flow headers like for (i = 1:100) or switch(EXPR) should be debuggable and at least interruptable by the ESC key.

Analysis:

Should be a not so hard change. Copy the debugger calling logic from the flow control body function to the header evaluation function.

Implementation:

  • Implementation: Implemented as indicated by the analysis. for statements needed some special treatment due to the fact that their header works a bit different.
  • Revision: [r1163]
  • Implementation test: A script with different mixtures of flow control statements was used as a playground for the debugger.

Documentation:

  • ChangesLog updated
  • Code changes commented
  • Documentation articles:
    • corresponding documentation articles updated
    • new documentation articles created
    • not needed
  • Language files:
    • corresponding language files updated
    • not needed

Tests:

A hardcoded breakpoint was added at a control flow header to the automatic SW test. No deviation detected.

Related

Commit: [r1163]

Discussion

  • Erik Hänel

    Erik Hänel - 2022-06-17
    • labels: --> ctrlflow, internal, debugger
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2022-06-17
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,23 @@
 Control flow headers like `for (i = 1:100)` or `switch(EXPR)` should be debuggable and at least interruptable by the ESC key.
+
+###Analysis:
+(*Describe, what's the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you've changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+
+###Documentation:
+* [ ] ChangesLog updated
+* [ ] Code changes commented
+* **Documentation articles:**
+    * [ ] corresponding documentation articles updated
+    * [ ] new documentation articles created
+    * [ ] not needed
+* **Language files:**
+    * [ ] corresponding language files updated
+    * [ ] not needed
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2022-06-17
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,7 +1,7 @@
 Control flow headers like `for (i = 1:100)` or `switch(EXPR)` should be debuggable and at least interruptable by the ESC key.

 ###Analysis:
-(*Describe, what's the issue and which changes have to be made*)
+Should be a not so hard change. Copy the debugger calling logic from the flow control body function to the header evaluation function.

 ###Implementation:
 * Implementation: (*Describe, what you've changed*)
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2022-06-17
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -4,20 +4,20 @@
 Should be a not so hard change. Copy the debugger calling logic from the flow control body function to the header evaluation function.

 ###Implementation:
-* Implementation: (*Describe, what you've changed*) 
-* Revision: [rXXX]
-* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+* Implementation: Implemented as indicated by the analysis. `for` statements needed some special treatment due to the fact that their header works a bit different.
+* Revision: [r1163]
+* Implementation test: A script with different mixtures of flow control statements was used as a playground for the debugger.

 ###Documentation:
-* [ ] ChangesLog updated
-* [ ] Code changes commented
+* [x] ChangesLog updated
+* [x] Code changes commented
 * **Documentation articles:**
     * [ ] corresponding documentation articles updated
     * [ ] new documentation articles created
-    * [ ] not needed
+    * [x] not needed
 * **Language files:**
     * [ ] corresponding language files updated
-    * [ ] not needed
+    * [x] not needed

 ###Tests:
 (*Describe, which tests you performed and their outcome*)
    • status: implementing --> testing
     

    Related

    Commit: [r1163]

  • Erik Hänel

    Erik Hänel - 2022-08-05
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -20,4 +20,4 @@
     * [x] not needed

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+A hardcoded breakpoint was added at a control flow header to the automatic SW test. No deviation detected.
    • status: testing --> closed
     

Anonymous
Anonymous

Add attachments
Cancel