Menu ▾ ▴

#700 Search result visibility

v1.1.x
closed
Erik Hänel
gui (58) editor (22)
v1.1.4
Change Request
2022-08-10
2022-05-14
Erik Hänel
No

When searching within the editor, ensure that the result is visible (not folded or hidden).

Analysis:

This requires that the code from NumeReEditor::FocusOnLine() is extracted into a new NumeReEditor::EnsureLineVisibility() method, which may then be called from NumeReWindow::FindString() instead of NumeReEditor::EnsureVisible().

Implementation:

  • Implementation: Implemented as proposed by the analysis.
  • Revision: [r1154]
  • Implementation test: A search termin, which was hidden or folded away previously, was searched and the matches were visible within the editor.

Documentation:

  • [x] ChangesLog updated
  • [x] Code changes commented
  • Documentation articles:
    • [ ] corresponding documentation articles updated
    • [ ] new documentation articles created
    • [x] not needed
  • Language files:
    • [ ] corresponding language files updated
    • [x] not needed

Tests:

Tested manually. No deviations detected.

Related

Commit: [r1154]

Discussion

  • Erik Hänel

    Erik Hänel - 2022-05-25
    • labels: --> gui, editor
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2022-05-25
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,23 @@
 When searching within the editor, ensure that the result is visible (not folded or hidden).
+
+###Analysis:
+(*Describe, what's the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you've changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+
+###Documentation:
+* [ ] ChangesLog updated
+* [ ] Code changes commented
+* **Documentation articles:**

+    * [ ] corresponding documentation articles updated
+    * [ ] new documentation articles created
+    * [ ] not needed
+* **Language files:**
+    * [ ] corresponding language files updated
+    * [ ] not needed
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2022-05-26
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,7 +1,7 @@
 When searching within the editor, ensure that the result is visible (not folded or hidden).

 ###Analysis:
-(*Describe, what's the issue and which changes have to be made*)
+This requires that the code from `NumeReEditor::FocusOnLine()` is extracted into a new `NumeReEditor::EnsureLineVisibility()` method, which may then be called from `NumeReWindow::FindString()` instead of `NumeReEditor::EnsureVisible()`.

 ###Implementation:

 * Implementation: (*Describe, what you've changed*)
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2022-05-26
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -4,20 +4,20 @@
 This requires that the code from `NumeReEditor::FocusOnLine()` is extracted into a new `NumeReEditor::EnsureLineVisibility()` method, which may then be called from `NumeReWindow::FindString()` instead of `NumeReEditor::EnsureVisible()`.

 ###Implementation:
-* Implementation: (*Describe, what you've changed*) 
-* Revision: [rXXX]
-* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+* Implementation: Implemented as proposed by the analysis.
+* Revision: [r1154]
+* Implementation test: A search termin, which was hidden or folded away previously, was searched and the matches were visible within the editor.

 ###Documentation:
-* [ ] ChangesLog updated
-* [ ] Code changes commented
+* [x] ChangesLog updated
+* [x] Code changes commented

 * **Documentation articles:**
     * [ ] corresponding documentation articles updated
     * [ ] new documentation articles created
-    * [ ] not needed
+    * [x] not needed
 * **Language files:**
     * [ ] corresponding language files updated
-    * [ ] not needed
+    * [x] not needed

 ###Tests:
 (*Describe, which tests you performed and their outcome*)
    • status: implementing --> testing
     

    Related

    Commit: [r1154]

  • Erik Hänel

    Erik Hänel - 2022-08-10
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -20,4 +20,4 @@

     * [x] not needed

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+Tested manually. No deviations detected.
    • status: testing --> closed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB