Menu ▾ ▴

#698 Returning quotation marks from procedures

v1.1.x
fixed
Erik Hänel
procedure (16) strings (14) internal (109)
v1.1.3
Bug Fix
2022-08-05
2022-05-02
Erik Hänel
No

If one returns a string containing quotation marks from a procedure a string error occurs. It's quite probable that the quotation marks within the string are erroneously detected as terminating quotation marks.

Analysis:

The issue is that not the actual string but the pre-formatted string for the terminal is returned. Change this to return the actual string, which will contain the correctly escaped quotation marks.

Implementation:

  • Implementation: Implemented with [#697] as indicated by the analysis.
  • Revision: [r1134]
  • Implementation test: The erroneous expression now works as intended.

Documentation:

  • [x] ChangesLog updated
  • [x] Code changes commented
  • Documentation articles:
    • [ ] corresponding documentation articles updated
    • [ ] new documentation articles created
    • [x] not needed
  • Language files:
    • [ ] corresponding language files updated
    • [x] not needed

Tests:

Tested manually. Detected deviation resulting from change in [#714] was resolved.

Related

Commit: [r1134]
Tickets: #697
Tickets: #714

Discussion

  • Erik Hänel

    Erik Hänel - 2022-05-02
    • labels: --> procedure, strings, internal
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2022-05-02
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,23 @@
 If one returns a string containing quotation marks from a procedure a string error occurs. It's quite probable that the quotation marks within the string are erroneously detected as terminating quotation marks.
+
+###Analysis:
+(*Describe, what's the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you've changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+
+###Documentation:
+* [ ] ChangesLog updated
+* [ ] Code changes commented
+* **Documentation articles:**

+    * [ ] corresponding documentation articles updated
+    * [ ] new documentation articles created
+    * [ ] not needed
+* **Language files:**
+    * [ ] corresponding language files updated
+    * [ ] not needed
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2022-05-02
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,7 +1,7 @@
 If one returns a string containing quotation marks from a procedure a string error occurs. It's quite probable that the quotation marks within the string are erroneously detected as terminating quotation marks.

 ###Analysis:
-(*Describe, what's the issue and which changes have to be made*)
+The issue is that not the actual string but the pre-formatted string for the terminal is returned. Change this to return the actual string, which will contain the correctly escaped quotation marks.

 ###Implementation:

 * Implementation: (*Describe, what you've changed*)
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2022-05-02
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -4,20 +4,20 @@
 The issue is that not the actual string but the pre-formatted string for the terminal is returned. Change this to return the actual string, which will contain the correctly escaped quotation marks.

 ###Implementation:
-* Implementation: (*Describe, what you've changed*) 
-* Revision: [rXXX]
-* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+* Implementation: Implemented with [#697] as indicated by the analysis.
+* Revision: [r1134]
+* Implementation test: The erroneous expression now works as intended.

 ###Documentation:
-* [ ] ChangesLog updated
-* [ ] Code changes commented
+* [x] ChangesLog updated
+* [x] Code changes commented

 * **Documentation articles:**
     * [ ] corresponding documentation articles updated
     * [ ] new documentation articles created
-    * [ ] not needed
+    * [x] not needed
 * **Language files:**
     * [ ] corresponding language files updated
-    * [ ] not needed
+    * [x] not needed

 ###Tests:
 (*Describe, which tests you performed and their outcome*)
    • status: implementing --> testing
     

    Related

    Commit: [r1134]
    Tickets: #697

  • Erik Hänel

    Erik Hänel - 2022-08-05
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -20,4 +20,4 @@

     * [x] not needed

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+Tested manually. Detected deviation resulting from change in [#714] was resolved.
    • status: testing --> fixed
     

    Related

    Tickets: #714

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB