Menu ▾ ▴

#691 Rework including logic

v1.1.x
closed
Erik Hänel
internal (109) cmd (19) procedure (16)
v1.1.4
Change Request
2022-08-09
2022-03-25
Erik Hänel
No

The current including logic always checks for scripts, which have a fitting name. This is not really practicable, because it requires scripts inside of packaged procedures. We have to define another type of includings. Additionally, the dependency viewer shall also detect includes (which is possible).

Analysis:

We'll implement the include command to replace the old @ syntax. This will support a similar syntax by include FILE :: ARGS to enable importing restrictions. We'll also enable the dependency detection within the package creator, but not within the dependency viewer due to the fact that include does not have to be part of any procedure.

Implementation:

  • Implementation: Implemented as indicated by the analysis.
  • Revision: [r1186]
  • Implementation test: The new command was used for including another file and worked as expected.

Documentation:

  • [x] ChangesLog updated
  • [x] Code changes commented
  • Documentation articles:
    • [x] corresponding documentation articles updated
    • [ ] new documentation articles created
    • [ ] not needed
  • Language files:
    • [x] corresponding language files updated
    • [ ] not needed

Tests:

New including logic was added to the automatic SW tests. No deviations detected.

Related

Commit: [r1186]

Discussion

  • Erik Hänel

    Erik Hänel - 2022-05-13
    • labels: --> internal, cmd, procedure
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2022-05-13
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,23 @@
 The current including logic always checks for scripts, which have a fitting name. This is not really practicable, because it requires scripts inside of packaged procedures. We have to define another type of includings. Additionally, the dependency viewer shall also detect includes (which is possible).
+
+###Analysis:
+(*Describe, what's the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you've changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+
+###Documentation:
+* [ ] ChangesLog updated
+* [ ] Code changes commented
+* **Documentation articles:**

+    * [ ] corresponding documentation articles updated
+    * [ ] new documentation articles created
+    * [ ] not needed
+* **Language files:**
+    * [ ] corresponding language files updated
+    * [ ] not needed
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2022-07-14
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,7 +1,7 @@
 The current including logic always checks for scripts, which have a fitting name. This is not really practicable, because it requires scripts inside of packaged procedures. We have to define another type of includings. Additionally, the dependency viewer shall also detect includes (which is possible).

 ###Analysis:
-(*Describe, what's the issue and which changes have to be made*)
+We'll implement the `include` command to replace the old `@` syntax. This will support a similar syntax by `include FILE :: ARGS` to enable importing restrictions. We'll also enable the dependency detection within the package creator, but not within the dependency viewer due to the fact that `include` does not have to be part of any procedure.

 ###Implementation:

 * Implementation: (*Describe, what you've changed*)
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2022-07-15
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -4,19 +4,19 @@
 We'll implement the `include` command to replace the old `@` syntax. This will support a similar syntax by `include FILE :: ARGS` to enable importing restrictions. We'll also enable the dependency detection within the package creator, but not within the dependency viewer due to the fact that `include` does not have to be part of any procedure.

 ###Implementation:
-* Implementation: (*Describe, what you've changed*) 
-* Revision: [rXXX]
-* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+* Implementation: Implemented as indicated by the analysis.
+* Revision: [r1186]
+* Implementation test: The new command was used for including another file and worked as expected.

 ###Documentation:
-* [ ] ChangesLog updated
-* [ ] Code changes commented
+* [x] ChangesLog updated
+* [x] Code changes commented

 * **Documentation articles:**
-    * [ ] corresponding documentation articles updated
+    * [x] corresponding documentation articles updated
     * [ ] new documentation articles created
     * [ ] not needed
 * **Language files:**
-    * [ ] corresponding language files updated
+    * [x] corresponding language files updated
     * [ ] not needed

 ###Tests:
    • status: implementing --> testing
     

    Related

    Commit: [r1186]

  • Erik Hänel

    Erik Hänel - 2022-08-09
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -20,4 +20,4 @@

     * [ ] not needed

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+New including logic was added to the automatic SW tests. No deviations detected.
    • status: testing --> closed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB