Menu ▾ ▴

#680 Inline procedures need table references

v1.1.x
fixed
Erik Hänel
internal (109) procedure (16)
v1.1.4
Bug Fix
2022-08-08
2022-03-15
Erik Hänel
No

Inline procedures, which get tables as arguments, always need them as references. Evaluate this behavior and either automatically force references or throw an error.

Analysis:

There are no temporary tables, therefore we'll need the references to actually access the data. Automatically forcing references is not reasonable as that might be surprising. We'll throw a decriptive error in this case.

Implementation:

  • Implementation: Fixed as mentionen in the analysis.
  • Revision: [r1102]
  • Implementation test: An inline procedure with a table as parameter was executed and the error was thrown as expected

Documentation:

  • [x] ChangesLog updated
  • [x] Code changes commented
  • Documentation articles:
    • [x] corresponding documentation articles updated
    • [ ] new documentation articles created
    • [ ] not needed
  • Language files:
    • [x] corresponding language files updated
    • [ ] not needed

Tests:

A corresponding test was created. An oversight was resolved in [r1199].

Related

Commit: [r1102]
Commit: [r1199]

Discussion

  • Erik Hänel

    Erik Hänel - 2022-03-15
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2022-03-21
    • labels: --> internal, procedure
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,23 @@
 Inline procedures, which get tables as arguments, always need them as references. Evaluate this behavior and either automatically force references or throw an error.
+
+###Analysis:
+(*Describe, what's the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you've changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+
+###Documentation:
+* [ ] ChangesLog updated
+* [ ] Code changes commented
+* **Documentation articles:**

+    * [ ] corresponding documentation articles updated
+    * [ ] new documentation articles created
+    * [ ] not needed
+* **Language files:**
+    * [ ] corresponding language files updated
+    * [ ] not needed
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2022-03-22
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,7 +1,7 @@
 Inline procedures, which get tables as arguments, always need them as references. Evaluate this behavior and either automatically force references or throw an error.

 ###Analysis:
-(*Describe, what's the issue and which changes have to be made*)
+There are no temporary tables, therefore we'll need the references to actually access the data. Automatically forcing references is not reasonable as that might be surprising. We'll throw a decriptive error in this case.

 ###Implementation:

 * Implementation: (*Describe, what you've changed*)
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2022-03-22
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -4,19 +4,19 @@
 There are no temporary tables, therefore we'll need the references to actually access the data. Automatically forcing references is not reasonable as that might be surprising. We'll throw a decriptive error in this case.

 ###Implementation:
-* Implementation: (*Describe, what you've changed*) 
-* Revision: [rXXX]
-* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+* Implementation: Fixed as mentionen in the analysis.
+* Revision: [r1102]
+* Implementation test: An inline procedure with a table as parameter was executed and the error was thrown as expected

 ###Documentation:
-* [ ] ChangesLog updated
-* [ ] Code changes commented
+* [x] ChangesLog updated
+* [x] Code changes commented

 * **Documentation articles:**
-    * [ ] corresponding documentation articles updated
+    * [x] corresponding documentation articles updated
     * [ ] new documentation articles created
     * [ ] not needed
 * **Language files:**
-    * [ ] corresponding language files updated
+    * [x] corresponding language files updated
     * [ ] not needed

 ###Tests:
    • status: implementing --> testing
     

    Related

    Commit: [r1102]

  • Erik Hänel

    Erik Hänel - 2022-08-08
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -20,4 +20,4 @@

     * [ ] not needed

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+A corresponding test was created. An oversight was resolved in [r1199].
    • status: testing --> fixed
     

    Related

    Commit: [r1199]

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB