Menu ▾ ▴

#65 to_uppercase() interferes with control chars

v1.0.x
fixed
Erik Hänel
None
v1.0.9
Bug Fix
2016-07-14
2016-06-28
Erik Hänel
No

The function to_uppercase() interferes with control chars like \n.

Analysis:
This is a simple bug fix to be done in the function

string toUpperCase(const string&)

Simply check, if two chars form a relevant control char and escape them.

Implementation:
Bug fix was implemented as proposed in the analysis.

Tests:
Tests were passed successfully. Bug fix accepted.

Discussion

  • Erik Hänel

    Erik Hänel - 2016-06-28
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2016-06-28
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,7 @@
 The function `to_uppercase()` interferes with control chars like `\n`.
+
+**Analysis:**
+
+**Implementation:**
+
+**Tests:**
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2016-06-28
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,6 +1,11 @@
 The function `to_uppercase()` interferes with control chars like `\n`.

 **Analysis:**
+This is a simple bug fix to be done in the function
+~~~C
+string toUpperCase(const string&)
+~~~
+Simply check, if two chars form a relevant control char and escape them.

 **Implementation:**
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2016-06-28
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -8,5 +8,6 @@
 Simply check, if two chars form a relevant control char and escape them.

 **Implementation:**
+Bug fix was implemented as proposed in the analysis.

 **Tests:**
    • status: implementing --> testing
     

  • Erik Hänel

    Erik Hänel - 2016-07-14
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -11,3 +11,4 @@
 Bug fix was implemented as proposed in the analysis.

 **Tests:**
+Tests were passed successfully. Bug fix accepted.
    • status: testing --> fixed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB