Menu ▾ ▴

#642 Improve 'new' command

v1.1.x
closed
Erik Hänel
cmd (19) internal (109)
v1.1.4
Change Request
2022-01-21
2021-09-09
Erik Hänel
No

The new command's code is really outdated and very buggy. Improve that.

Analysis:

Use the new CommandLineParser class to wrap all unecessary code. Use also the new features, which are available in the meantime.

Implementation:

  • Implementation: Implemented as proposed by the analysis.
  • Revision: [r1022]
  • Implementation test: new was used with all relevant combinations

Documentation:

  • ChangesLog updated
  • Code changes commented
  • Documentation articles:
    • corresponding documentation articles updated
    • new documentation articles created
    • not needed
  • Language files:
    • corresponding language files updated
    • not needed

Tests:

Change was tested manually. No deviations detected.

Related

Commit: [r1022]

Discussion

  • Erik Hänel

    Erik Hänel - 2021-09-11
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2021-10-16
    • labels: --> cmd, internal
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,23 @@
 The `new` command's code is really outdated and very buggy. Improve that.
+
+###Analysis:
+(*Describe, what's the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you've changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+
+###Documentation:
+* [ ] ChangesLog updated
+* [ ] Code changes commented
+* **Documentation articles:**
+    * [ ] corresponding documentation articles updated
+    * [ ] new documentation articles created
+    * [ ] not needed
+* **Language files:**
+    * [ ] corresponding language files updated
+    * [ ] not needed
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2021-10-18
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,7 +1,7 @@
 The `new` command's code is really outdated and very buggy. Improve that.

 ###Analysis:
-(*Describe, what's the issue and which changes have to be made*)
+Use the new `CommandLineParser` class to wrap all unecessary code. Use also the new features, which are available in the meantime.

 ###Implementation:
 * Implementation: (*Describe, what you've changed*)
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2021-10-18
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -4,19 +4,19 @@
 Use the new `CommandLineParser` class to wrap all unecessary code. Use also the new features, which are available in the meantime.

 ###Implementation:
-* Implementation: (*Describe, what you've changed*) 
-* Revision: [rXXX]
-* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+* Implementation: Implemented as proposed by the analysis.
+* Revision: [r1022]
+* Implementation test: `new` was used with all relevant combinations

 ###Documentation:
 * [ ] ChangesLog updated
-* [ ] Code changes commented
+* [x] Code changes commented
 * **Documentation articles:**
     * [ ] corresponding documentation articles updated
     * [ ] new documentation articles created
-    * [ ] not needed
+    * [x] not needed
 * **Language files:**
-    * [ ] corresponding language files updated
+    * [x] corresponding language files updated
     * [ ] not needed

 ###Tests:
    • status: implementing --> testing
     

    Related

    Commit: [r1022]

  • Erik Hänel

    Erik Hänel - 2022-01-21
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -20,4 +20,4 @@
     * [ ] not needed

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+Change was tested manually. No deviations detected.
    • status: testing --> closed
     

Anonymous
Anonymous

Add attachments
Cancel