Menu ▾ ▴

#627 Statistics and selecting multiple columns or rows

v1.1.x
fixed
Erik Hänel
gui (58) tableviewer (4)
v1.1.3
Bug Fix
2022-01-17
2021-08-21
Erik Hänel
No

If one selects multiple columns or rows in the table viewer the statistics are only calculated for the last selected column/row instead for all selected ones.

Analysis:

The event handler void TableViewer::OnCellRangeSelect(wxGridRangeSelectEvent& event) does only handle the latest selected row or column. Therefore, we have to cache the currently selected coordinates and re-calculate the topleft and bottomright corners each time, the handler is called.

Implementation:

  • Implementation: Implemented as proposed by the analysis.
  • Revision: [r1001]
  • Implementation test: Statistics of multiple columns were calculated.

Documentation:

  • ChangesLog updated
  • Code changes commented
  • Documentation articles:
    • corresponding documentation articles updated
    • new documentation articles created
    • not needed
  • Language files:
    • corresponding language files updated
    • not needed

Tests:

Fix was tested manually. No deviations detected.

Related

Commit: [r1001]

Discussion

  • Erik Hänel

    Erik Hänel - 2021-08-24
    • labels: --> gui, tableviewer
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2021-08-24
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,23 @@
 If one selects multiple columns or rows in the table viewer the statistics are only calculated for the last selected column/row instead for all selected ones.
+
+###Analysis:
+(*Describe, what's the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you've changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+
+###Documentation:
+* [ ] ChangesLog updated
+* [ ] Code changes commented
+* **Documentation articles:**
+    * [ ] corresponding documentation articles updated
+    * [ ] new documentation articles created
+    * [ ] not needed
+* **Language files:**
+    * [ ] corresponding language files updated
+    * [ ] not needed
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2021-09-06
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,7 +1,7 @@
 If one selects multiple columns or rows in the table viewer the statistics are only calculated for the last selected column/row instead for all selected ones.

 ###Analysis:
-(*Describe, what's the issue and which changes have to be made*)
+The event handler `void TableViewer::OnCellRangeSelect(wxGridRangeSelectEvent& event)` does only handle the latest selected row or column. Therefore, we have to cache the currently selected coordinates and re-calculate the topleft and bottomright corners each time, the handler is called.

 ###Implementation:
 * Implementation: (*Describe, what you've changed*)
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2021-09-07
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -4,20 +4,20 @@
 The event handler `void TableViewer::OnCellRangeSelect(wxGridRangeSelectEvent& event)` does only handle the latest selected row or column. Therefore, we have to cache the currently selected coordinates and re-calculate the topleft and bottomright corners each time, the handler is called.

 ###Implementation:
-* Implementation: (*Describe, what you've changed*) 
-* Revision: [rXXX]
-* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+* Implementation: Implemented as proposed by the analysis.
+* Revision: [r1001]
+* Implementation test: Statistics of multiple columns were calculated.

 ###Documentation:
-* [ ] ChangesLog updated
-* [ ] Code changes commented
+* [x] ChangesLog updated
+* [x] Code changes commented
 * **Documentation articles:**
     * [ ] corresponding documentation articles updated
     * [ ] new documentation articles created
-    * [ ] not needed
+    * [x] not needed
 * **Language files:**
     * [ ] corresponding language files updated
-    * [ ] not needed
+    * [x] not needed

 ###Tests:
 (*Describe, which tests you performed and their outcome*)
    • status: implementing --> testing
     

    Related

    Commit: [r1001]

  • Erik Hänel

    Erik Hänel - 2022-01-17
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -20,4 +20,4 @@
     * [x] not needed

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+Fix was tested manually. No deviations detected.
    • status: testing --> fixed
     

Anonymous
Anonymous

Add attachments
Cancel