Menu

#622 GUI scaling at higher display scalings

v1.1.x
fixed
v1.1.3
Bug Fix
2022-01-17
2021-08-19
Erik Hänel
No

If the user display scaling is higher than 100%, the option window is not usable.

Analysis:

We'll use the pixelscale, which was determined by the IconManager at startup as a global constant to correctly calculated the actual pixels for the erroneous dialogs.

Implementation:

  • Implementation: Implemented as proposed by the analysis.
  • Revision: [r1002]
  • Implementation test: All dialogs were opened at 125% display scaling

Documentation:

  • ChangesLog updated
  • Code changes commented
  • Documentation articles:
    • corresponding documentation articles updated
    • new documentation articles created
    • not needed
  • Language files:
    • corresponding language files updated
    • not needed

Tests:

Fix was tested on a High-DPI monitor. No deviations detected.

Related

Commit: [r1002]

Discussion

  • Erik Hänel

    Erik Hänel - 2021-08-24
    • labels: --> gui, dpiscaling
    • status: open --> accepted
     
  • Erik Hänel

    Erik Hänel - 2021-08-24
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1 +1,23 @@
     If the user display scaling is higher than 100%, the option window is not usable.
    +
    +###Analysis:
    +(*Describe, what's the issue and which changes have to be made*)
    +
    +###Implementation:
    +* Implementation: (*Describe, what you've changed*) 
    +* Revision: [rXXX]
    +* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
    +
    +###Documentation:
    +* [ ] ChangesLog updated
    +* [ ] Code changes commented
    +* **Documentation articles:**
    +    * [ ] corresponding documentation articles updated
    +    * [ ] new documentation articles created
    +    * [ ] not needed
    +* **Language files:**
    +    * [ ] corresponding language files updated
    +    * [ ] not needed
    +
    +###Tests:
    +(*Describe, which tests you performed and their outcome*)
    
    • status: accepted --> analyzing
     
  • Erik Hänel

    Erik Hänel - 2021-09-07
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1,7 +1,7 @@
     If the user display scaling is higher than 100%, the option window is not usable.
    
     ###Analysis:
    -(*Describe, what's the issue and which changes have to be made*)
    +We'll use the pixelscale, which was determined by the `IconManager` at startup as a global constant to correctly calculated the actual pixels for the erroneous dialogs.
    
     ###Implementation:
     * Implementation: (*Describe, what you've changed*) 
    
    • status: analyzing --> implementing
     
  • Erik Hänel

    Erik Hänel - 2021-09-07
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -4,20 +4,20 @@
     We'll use the pixelscale, which was determined by the `IconManager` at startup as a global constant to correctly calculated the actual pixels for the erroneous dialogs.
    
     ###Implementation:
    -* Implementation: (*Describe, what you've changed*) 
    -* Revision: [rXXX]
    -* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
    +* Implementation: Implemented as proposed by the analysis.
    +* Revision: [r1002]
    +* Implementation test: All dialogs were opened at 125% display scaling
    
     ###Documentation:
    -* [ ] ChangesLog updated
    +* [x] ChangesLog updated
     * [ ] Code changes commented
     * **Documentation articles:**
         * [ ] corresponding documentation articles updated
         * [ ] new documentation articles created
    -    * [ ] not needed
    +    * [x] not needed
     * **Language files:**
         * [ ] corresponding language files updated
    -    * [ ] not needed
    +    * [x] not needed
    
     ###Tests:
     (*Describe, which tests you performed and their outcome*)
    
    • status: implementing --> testing
     

    Related

    Commit: [r1002]

  • Erik Hänel

    Erik Hänel - 2022-01-17
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -20,4 +20,4 @@
         * [x] not needed
    
     ###Tests:
    -(*Describe, which tests you performed and their outcome*)
    +Fix was tested on a High-DPI monitor. No deviations detected.
    
    • status: testing --> fixed
     

Anonymous
Anonymous

Add attachments
Cancel