Menu ▾ ▴

#620 Procedure names and namespaces containing operators

v1.1.x
fixed
Erik Hänel
procedure (16)
v1.1.3
Bug Fix
2022-01-18
2021-08-19
Erik Hänel
No

Procedure names and namespaces may not contain mathematical operators. Check, whether they're sometimes implicitly allowed and fix this.

Analysis:

We can do the following:

  • Auto-replace unwanted chars during autocreation of procedures in the editor (or throw an error)
  • Auto-replace unwanted chars during creation of procedures using a functionality
  • Add a check to the static code analyzer

Implementation:

  • Implementation: Implemented as proposed by the analysis
  • Revision: [r1007]
  • Implementation test: Procedures with non-alphanumeric characters were tried to use and yielded errors or automatic conversions

Documentation:

  • ChangesLog updated
  • Code changes commented
  • Documentation articles:
    • corresponding documentation articles updated
    • new documentation articles created
    • not needed
  • Language files:
    • corresponding language files updated
    • not needed

Tests:

Fix was tested manually. No deviations detected.

Related

Commit: [r1007]

Discussion

  • Erik Hänel

    Erik Hänel - 2021-08-24
    • labels: --> procedure
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2021-08-24
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,23 @@
 Procedure names and namespaces may not contain mathematical operators. Check, whether they're sometimes implicitly allowed and fix this.
+
+###Analysis:
+(*Describe, what's the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you've changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+
+###Documentation:
+* [ ] ChangesLog updated
+* [ ] Code changes commented
+* **Documentation articles:**
+    * [ ] corresponding documentation articles updated
+    * [ ] new documentation articles created
+    * [ ] not needed
+* **Language files:**
+    * [ ] corresponding language files updated
+    * [ ] not needed
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2021-09-09
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,7 +1,11 @@
 Procedure names and namespaces may not contain mathematical operators. Check, whether they're sometimes implicitly allowed and fix this.

 ###Analysis:
-(*Describe, what's the issue and which changes have to be made*)
+We can do the following:
+
+- Auto-replace unwanted chars during autocreation of procedures in the editor (or throw an error)
+- Auto-replace unwanted chars during creation of procedures using a functionality
+- Add a check to the static code analyzer

 ###Implementation:
 * Implementation: (*Describe, what you've changed*)
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2021-09-09
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -8,20 +8,20 @@
 - Add a check to the static code analyzer

 ###Implementation:
-* Implementation: (*Describe, what you've changed*) 
-* Revision: [rXXX]
-* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+* Implementation: Implemented as proposed by the analysis
+* Revision: [r1007]
+* Implementation test: Procedures with non-alphanumeric characters were tried to use and yielded errors or automatic conversions

 ###Documentation:
-* [ ] ChangesLog updated
-* [ ] Code changes commented
+* [x] ChangesLog updated
+* [x] Code changes commented
 * **Documentation articles:**
     * [ ] corresponding documentation articles updated
     * [ ] new documentation articles created
-    * [ ] not needed
+    * [x] not needed
 * **Language files:**
     * [ ] corresponding language files updated
-    * [ ] not needed
+    * [x] not needed

 ###Tests:
 (*Describe, which tests you performed and their outcome*)
    • status: implementing --> testing
     

    Related

    Commit: [r1007]

  • Erik Hänel

    Erik Hänel - 2022-01-18
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -24,4 +24,4 @@
     * [x] not needed

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+Fix was tested manually. No deviations detected.
    • status: testing --> fixed
     

Anonymous
Anonymous

Add attachments
Cancel