Menu ▾ ▴

#619 Name mangling in external procedures

v1.1.x
fixed
Erik Hänel
procedure (16)
v1.1.3
Bug Fix
2022-01-18
2021-08-19
Erik Hänel
No

Procedures, which are not located in the default folders have issues with their local variables and return values due to the internal name mangling

Analysis:

The name mangling for external procedures is already present but not fully implemented in the ProcedureVarFactory. Improve this mangling to resolve this issue.

Implementation:

  • Implementation: Implemented as proposed by the analysis.
  • Revision: [r1006]
  • Implementation test: An external procedure was used with a dot in the folder path. No deviation was detected.

Documentation:

  • ChangesLog updated
  • Code changes commented
  • Documentation articles:
    • corresponding documentation articles updated
    • new documentation articles created
    • not needed
  • Language files:
    • corresponding language files updated
    • not needed

Tests:

Fix was added to the automatic SW tests and will be executed, if the correct file is available. No deviations detected.

Related

Commit: [r1006]

Discussion

  • Erik Hänel

    Erik Hänel - 2021-08-24
    • labels: --> procedure
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2021-08-24
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,23 @@
 Procedures, which are not located in the default folders have issues with their local variables and return values due to the internal name mangling
+
+###Analysis:
+(*Describe, what's the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you've changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+
+###Documentation:
+* [ ] ChangesLog updated
+* [ ] Code changes commented
+* **Documentation articles:**
+    * [ ] corresponding documentation articles updated
+    * [ ] new documentation articles created
+    * [ ] not needed
+* **Language files:**
+    * [ ] corresponding language files updated
+    * [ ] not needed
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2021-09-08
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,7 +1,7 @@
 Procedures, which are not located in the default folders have issues with their local variables and return values due to the internal name mangling

 ###Analysis:
-(*Describe, what's the issue and which changes have to be made*)
+The name mangling for external procedures is already present but not fully implemented in the `ProcedureVarFactory`. Improve this mangling to resolve this issue.

 ###Implementation:
 * Implementation: (*Describe, what you've changed*)
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2021-09-08
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -4,20 +4,20 @@
 The name mangling for external procedures is already present but not fully implemented in the `ProcedureVarFactory`. Improve this mangling to resolve this issue.

 ###Implementation:
-* Implementation: (*Describe, what you've changed*) 
-* Revision: [rXXX]
-* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+* Implementation: Implemented as proposed by the analysis.
+* Revision: [r1006]
+* Implementation test: An external procedure was used with a dot in the folder path. No deviation was detected.

 ###Documentation:
-* [ ] ChangesLog updated
-* [ ] Code changes commented
+* [x] ChangesLog updated
+* [x] Code changes commented
 * **Documentation articles:**
     * [ ] corresponding documentation articles updated
     * [ ] new documentation articles created
-    * [ ] not needed
+    * [x] not needed
 * **Language files:**
     * [ ] corresponding language files updated
-    * [ ] not needed
+    * [x] not needed

 ###Tests:
 (*Describe, which tests you performed and their outcome*)
    • status: implementing --> testing
     

    Related

    Commit: [r1006]

  • Erik Hänel

    Erik Hänel - 2022-01-18
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -20,4 +20,4 @@
     * [x] not needed

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+Fix was added to the automatic SW tests and will be executed, if the correct file is available. No deviations detected.
    • status: testing --> fixed
     

Anonymous
Anonymous

Add attachments
Cancel