Menu ▾ ▴

#616 Use new complex numbers for fft

v1.1.x
closed
Erik Hänel
complex (3)
v1.1.4
Change Request
2022-01-19
2021-08-01
Erik Hänel
No

Has to be done after [#554] and [#601] due to the fact that tables first have to support complex numbers.

The fft algorithm shall automatically use the complex numbers from the table without the need of specifying complex. However, it still has to be available for pure real number support.

Analysis:

It seems that this only requires two small changes: one change during copying the data to mglData and one during copying the fft back to Memory.

Implementation:

  • Implementation: Feature was implemented as indicated by the analysis.
  • Revision: [r992]
  • Implementation test: The SW tests were enhanced and ran without deviation.

Documentation:

  • ChangesLog updated
  • Code changes commented
  • Documentation articles:
    • corresponding documentation articles updated
    • new documentation articles created
    • not needed
  • Language files:
    • corresponding language files updated
    • not needed

Tests:

Already part of the automatic SW tests. No deviations detected.

Related

Commit: [r992]
Tickets: #554
Tickets: #597
Tickets: #601

Discussion

  • Erik Hänel

    Erik Hänel - 2021-08-18
    • labels: --> complex
     

  • Erik Hänel

    Erik Hänel - 2021-08-24
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2021-08-24
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,3 +1,25 @@
 Has to be done after [#554] and [#601] due to the fact that tables first have to support complex numbers.

 The `fft` algorithm shall automatically use the complex numbers from the table without the need of specifying `complex`. However, it still has to be available for pure real number support.
+
+###Analysis:
+(*Describe, what's the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you've changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+
+###Documentation:
+* [ ] ChangesLog updated
+* [ ] Code changes commented
+* **Documentation articles:**
+    * [ ] corresponding documentation articles updated
+    * [ ] new documentation articles created
+    * [ ] not needed
+* **Language files:**
+    * [ ] corresponding language files updated
+    * [ ] not needed
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
     

    Related

    Tickets: #554
    Tickets: #601

  • Erik Hänel

    Erik Hänel - 2021-08-24
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -3,7 +3,7 @@
 The `fft` algorithm shall automatically use the complex numbers from the table without the need of specifying `complex`. However, it still has to be available for pure real number support.

 ###Analysis:
-(*Describe, what's the issue and which changes have to be made*)
+It seems that this only requires two small changes: one change during copying the data to `mglData` and one during copying the fft back to `Memory`.

 ###Implementation:
 * Implementation: (*Describe, what you've changed*)
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2021-08-25
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -6,20 +6,20 @@
 It seems that this only requires two small changes: one change during copying the data to `mglData` and one during copying the fft back to `Memory`.

 ###Implementation:
-* Implementation: (*Describe, what you've changed*) 
-* Revision: [rXXX]
-* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+* Implementation: Feature was implemented as indicated by the analysis. 
+* Revision: [r992]
+* Implementation test: The SW tests were enhanced and ran without deviation.

 ###Documentation:
-* [ ] ChangesLog updated
-* [ ] Code changes commented
+* [x] ChangesLog updated
+* [x] Code changes commented
 * **Documentation articles:**
-    * [ ] corresponding documentation articles updated
+    * [x] corresponding documentation articles updated
     * [ ] new documentation articles created
     * [ ] not needed
 * **Language files:**
     * [ ] corresponding language files updated
-    * [ ] not needed
+    * [x] not needed

 ###Tests:
 (*Describe, which tests you performed and their outcome*)
    • status: implementing --> testing
     

    Related

    Commit: [r992]

  • Erik Hänel

    Erik Hänel - 2022-01-19
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -22,4 +22,4 @@
     * [x] not needed

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+Already part of the automatic SW tests. No deviations detected.
    • status: testing --> closed
     

Anonymous
Anonymous

Add attachments
Cancel