Menu

#613 Create analyzer error for 'mode-specific' functions

v1.1.x
closed
v1.1.4
New Functionality
2022-01-17
2021-07-27
Erik Hänel
No

Some functions (i.e. draw functions and matop functions) are only valid in this specific mode. Add an error message for the static code analyzer to detect such errors before runtime.

Analysis:

Straightforward change by storing the current line mode (consider line continuation marks) and checking all found functions against a list of known functions.

Implementation:

  • Implementation: Implemented as proposed by the analysis.
  • Revision: [r1013]
  • Implementation test: Modes were changed and the corresponding errors were shown.

Documentation:

  • ChangesLog updated
  • Code changes commented
  • Documentation articles:
    • corresponding documentation articles updated
    • new documentation articles created
    • not needed
  • Language files:
    • corresponding language files updated
    • not needed

Tests:

Functionality was tested manually. Occured deviation was fixed by removing a classification of some stats functions.

Related

Commit: [r1013]

Discussion

  • Erik Hänel

    Erik Hänel - 2021-08-16
    • status: open --> accepted
     
  • Erik Hänel

    Erik Hänel - 2021-08-16
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1 +1,23 @@
     Some functions (i.e. `draw` functions and `matop` functions) are only valid in this specific mode. Add an error message for the static code analyzer to detect such errors before runtime.
    +
    +###Analysis:
    +(*Describe, what's the issue and which changes have to be made*)
    +
    +###Implementation:
    +* Implementation: (*Describe, what you've changed*) 
    +* Revision: [rXXX]
    +* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
    +
    +###Documentation:
    +* [ ] ChangesLog updated
    +* [ ] Code changes commented
    +* **Documentation articles:**
    +    * [ ] corresponding documentation articles updated
    +    * [ ] new documentation articles created
    +    * [ ] not needed
    +* **Language files:**
    +    * [ ] corresponding language files updated
    +    * [ ] not needed
    +
    +###Tests:
    +(*Describe, which tests you performed and their outcome*)
    
    • status: accepted --> analyzing
     
  • Erik Hänel

    Erik Hänel - 2021-08-18
    • labels: --> gui, editor
     
  • Erik Hänel

    Erik Hänel - 2021-09-17
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1,7 +1,7 @@
     Some functions (i.e. `draw` functions and `matop` functions) are only valid in this specific mode. Add an error message for the static code analyzer to detect such errors before runtime.
    
     ###Analysis:
    -(*Describe, what's the issue and which changes have to be made*)
    +Straightforward change by storing the current line mode (consider line continuation marks) and checking all found functions against a list of known functions.
    
     ###Implementation:
     * Implementation: (*Describe, what you've changed*) 
    
    • status: analyzing --> implementing
     
  • Erik Hänel

    Erik Hänel - 2021-09-17
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -4,19 +4,19 @@
     Straightforward change by storing the current line mode (consider line continuation marks) and checking all found functions against a list of known functions.
    
     ###Implementation:
    -* Implementation: (*Describe, what you've changed*) 
    -* Revision: [rXXX]
    -* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
    +* Implementation: Implemented as proposed by the analysis.
    +* Revision: [r1013]
    +* Implementation test: Modes were changed and the corresponding errors were shown.
    
     ###Documentation:
    -* [ ] ChangesLog updated
    -* [ ] Code changes commented
    +* [x] ChangesLog updated
    +* [x] Code changes commented
     * **Documentation articles:**
         * [ ] corresponding documentation articles updated
         * [ ] new documentation articles created
    -    * [ ] not needed
    +    * [x] not needed
     * **Language files:**
    -    * [ ] corresponding language files updated
    +    * [x] corresponding language files updated
         * [ ] not needed
    
     ###Tests:
    
    • status: implementing --> testing
     

    Related

    Commit: [r1013]

  • Erik Hänel

    Erik Hänel - 2022-01-17
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -20,4 +20,4 @@
         * [ ] not needed
    
     ###Tests:
    -(*Describe, which tests you performed and their outcome*)
    +Functionality was tested manually. Occured deviation was fixed by removing a classification of some stats functions.
    
    • status: testing --> closed
     

Anonymous
Anonymous

Add attachments
Cancel