Menu ▾ ▴

#607 Clean language files

v1.1.x
closed
Erik Hänel
internal (109) language (4)
v1.1.4
Change Request
2022-01-17
2021-07-27
Erik Hänel
No

The language files need some cleaning up: remove syntax-specific strings from main.nlng and create a new language file for those strings, e.g. numere.nlng (indicating that this is the language-specific file).

Analysis:

This needs an extension of void Language::loadStrings(bool bloadUserFiles) in kernel/core/ui/language.cpp. Here, the list of files, which shall be read, are hardcoded. The new file has to be referenced in this file (E.g. by calling loadAndInsert("<>/lang/numere.nlng") and loadAndInsert("<>/lang/numere.nlng") for the user files).

The following tokens shall at least be moved:

  • PARSERFUNCS_LISTFUNC_* (and the four DEFINED_FOR_*)
  • PARSERFUNCS_LISTCMD_*
  • PARSERFUNCS_LISTUNITS_*
  • GUI_EDITOR_CALLTIP_*

Implementation:

  • Implementation: Split the main.nlnp into two files main.nlnp and numere.nlnp as described above. Also added the code to load this new language file. The file name is hard coded, just as the other two files.
  • Revision: [r1034]
  • Implementation test: (Describe the type of test, which you performed, and if it was successful)

Documentation:

  • [x] ChangesLog updated
  • [x] Code changes commented
  • Documentation articles:
    • [ ] corresponding documentation articles updated
    • [ ] new documentation articles created
    • [x] not needed
  • Language files:
    • [x] corresponding language files updated
    • [ ] not needed

Tests:

Change was already tested during development. No deviations detected.

Related

Commit: [r1034]

Discussion

  • Erik Hänel

    Erik Hänel - 2021-08-16
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2021-08-16
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,23 @@
 The language files need some cleaning up: remove syntax-specific strings from `main.nlng` and create a new language file for those strings, e.g. `numere.nlng` (indicating that this is the language-specific file).
+
+###Analysis:
+(*Describe, what&#39;s the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you&#39;ve changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+
+###Documentation:
+* [ ] ChangesLog updated
+* [ ] Code changes commented
+* **Documentation articles:**

+    * [ ] corresponding documentation articles updated
+    * [ ] new documentation articles created
+    * [ ] not needed
+* **Language files:**
+    * [ ] corresponding language files updated
+    * [ ] not needed
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2021-08-16
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,7 +1,7 @@
 The language files need some cleaning up: remove syntax-specific strings from `main.nlng` and create a new language file for those strings, e.g. `numere.nlng` (indicating that this is the language-specific file).

 ###Analysis:
-(*Describe, what&#39;s the issue and which changes have to be made*)
+This needs an extension of `void Language::loadStrings(bool bloadUserFiles)` in `kernel/core/ui/language.cpp`. Here, the list of files, which shall be read, are hardcoded. The new file has to be referenced in this file (E.g. by calling `loadAndInsert(&#34;&lt;&gt;/lang/numere.nlng&#34;)` and `loadAndInsert(&#34;&lt;&gt;/lang/numere.nlng&#34;)` for the user files).

 ###Implementation:

 * Implementation: (*Describe, what you&#39;ve changed*)
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2021-08-18
    • labels: --> internal, language
     

  • Erik Hänel

    Erik Hänel - 2021-11-03
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -2,6 +2,13 @@

 ###Analysis:
 This needs an extension of `void Language::loadStrings(bool bloadUserFiles)` in `kernel/core/ui/language.cpp`. Here, the list of files, which shall be read, are hardcoded. The new file has to be referenced in this file (E.g. by calling `loadAndInsert(&#34;&lt;&gt;/lang/numere.nlng&#34;)` and `loadAndInsert(&#34;&lt;&gt;/lang/numere.nlng&#34;)` for the user files).
+
+The following tokens shall at least be moved:
+
+* `PARSERFUNCS_LISTFUNC_*` (and the four `DEFINED_FOR_*`)
+* `PARSERFUNCS_LISTCMD_*`
+* `PARSERFUNCS_LISTUNITS_*`
+* `GUI_EDITOR_CALLTIP_*`

 ###Implementation:

 * Implementation: (*Describe, what you&#39;ve changed*)
    • assigned_to: Erik Hänel --> Raphael Zehner
     

  • Raphael Zehner

    Raphael Zehner - 2021-11-03
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -11,19 +11,19 @@

 * `GUI_EDITOR_CALLTIP_*`

 ###Implementation:
-* Implementation: (*Describe, what you&#39;ve changed*) 
-* Revision: [rXXX]
+* Implementation: Split the main.nlnp into two files main.nlnp and numere.nlnp as described above. Also added the code to load this new language file. The file name is hard coded, just as the other two files.
+* Revision: [r1034]

 * Implementation test: (*Describe the type of test, which you performed, and if it was successful*)

 ###Documentation:
-* [ ] ChangesLog updated
-* [ ] Code changes commented
+* [x] ChangesLog updated
+* [x] Code changes commented

 * **Documentation articles:**
     * [ ] corresponding documentation articles updated
     * [ ] new documentation articles created
-    * [ ] not needed
+    * [x] not needed
 * **Language files:**
-    * [ ] corresponding language files updated
+    * [x] corresponding language files updated
     * [ ] not needed

 ###Tests:
    • status: implementing --> testing
    • assigned_to: Raphael Zehner --> Erik Hänel
     

    Related

    Commit: [r1034]

  • Erik Hänel

    Erik Hänel - 2022-01-17
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -27,4 +27,4 @@

     * [ ] not needed

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+Change was already tested during development. No deviations detected.
    • status: testing --> closed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB