Menu ▾ ▴

#594 Enable 64 bit times (avoid Y2K38 issue)

v1.1.x
fixed
Erik Hänel
None
v1.1.2
Bug Fix
2021-07-12
2021-06-19
Erik Hänel
No

All time-based functions (not clock()) should use their 64bit counterpart, i.e. _time64(). It might be necessary to fiddle a bit with the MSVC versions to enable this.

Analysis:

Changing this does not seem to require any changes - however it needs a new version of the NDAT version to cope with the 64 bits __time64_t used in this case.

Implementation:

  • Implementation: Fix was implemented as proposed by the analysis. The current NDAT file version is now 2.1
  • Revision: [r912]
  • Implementation test: time conversions were performed and file types were written and read.

Documentation:

  • [x] ChangesLog updated
  • [x] Code changes commented
  • Documentation articles:
    • [ ] corresponding documentation articles updated
    • [ ] new documentation articles created
    • [x] not needed
  • Language files:
    • [ ] corresponding language files updated
    • [x] not needed

Tests:

Fix cannot be tested completely. We'll accept it as is.

Related

Commit: [r912]

Discussion

  • Erik Hänel

    Erik Hänel - 2021-06-19
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2021-06-23
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,23 @@
 All time-based functions (not `clock()`) should use their 64bit counterpart, i.e. `_time64()`. It might be necessary to fiddle a bit with the MSVC versions to enable this.
+
+###Analysis:
+(*Describe, what's the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you've changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+
+###Documentation:
+* [ ] ChangesLog updated
+* [ ] Code changes commented
+* **Documentation articles:**

+    * [ ] corresponding documentation articles updated
+    * [ ] new documentation articles created
+    * [ ] not needed
+* **Language files:**
+    * [ ] corresponding language files updated
+    * [ ] not needed
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2021-06-23
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,7 +1,7 @@
 All time-based functions (not `clock()`) should use their 64bit counterpart, i.e. `_time64()`. It might be necessary to fiddle a bit with the MSVC versions to enable this.

 ###Analysis:
-(*Describe, what's the issue and which changes have to be made*)
+Changing this does not seem to require any changes - however it needs a new version of the NDAT version to cope with the 64 bits `__time64_t` used in this case.

 ###Implementation:

 * Implementation: (*Describe, what you've changed*)
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2021-06-23
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -4,20 +4,20 @@
 Changing this does not seem to require any changes - however it needs a new version of the NDAT version to cope with the 64 bits `__time64_t` used in this case.

 ###Implementation:
-* Implementation: (*Describe, what you've changed*) 
-* Revision: [rXXX]
-* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+* Implementation: Fix was implemented as proposed by the analysis. The current NDAT file version is now 2.1
+* Revision: [r912]
+* Implementation test: time conversions were performed and file types were written and read.

 ###Documentation:
-* [ ] ChangesLog updated
-* [ ] Code changes commented
+* [x] ChangesLog updated
+* [x] Code changes commented

 * **Documentation articles:**
     * [ ] corresponding documentation articles updated
     * [ ] new documentation articles created
-    * [ ] not needed
+    * [x] not needed
 * **Language files:**
     * [ ] corresponding language files updated
-    * [ ] not needed
+    * [x] not needed

 ###Tests:
 (*Describe, which tests you performed and their outcome*)
    • status: implementing --> testing
     

    Related

    Commit: [r912]

  • Erik Hänel

    Erik Hänel - 2021-07-12
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -20,4 +20,4 @@

     * [x] not needed

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+Fix cannot be tested completely. We'll accept it as is.
    • status: testing --> fixed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB