Menu ▾ ▴

#593 Goto procedure definition cannot handle relative namespaces

v1.1.x
fixed
Erik Hänel
None
v1.1.2
Bug Fix
2021-07-14
2021-06-19
Erik Hänel
No

The "Goto procedure definition" functionality may not find procedures referenced using a relative namespace like $this~tests~procedure().

Analysis:

As in the similiar, previous issue, the following lines are missing in NumeReEditor::FindAndOpenProcedure():

while (pathname.find('~') != string::npos)
        pathname[pathname.find('~')] = '\\';

Implementation:

  • Implementation: The fix was implemented as proposed by the analysis.
  • Revision: [r902]
  • Implementation test: Functionality was tested using the usual shortcuts.

Documentation:

  • [x] ChangesLog updated
  • [x] Code changes commented
  • Documentation articles:
    • [ ] corresponding documentation articles updated
    • [ ] new documentation articles created
    • [x] not needed
  • Language files:
    • [ ] corresponding language files updated
    • [x] not needed

Tests:

Fix was tested manually. No deviation occured.

Related

Commit: [r902]

Discussion

  • Erik Hänel

    Erik Hänel - 2021-06-19
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1 @@
-The "Goto procedure definition" functionality may not find procedures references using a relative namespace like `$this~tests~procedure()`.
+The "Goto procedure definition" functionality may not find procedures referenced using a relative namespace like `$this~tests~procedure()`.
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2021-06-20
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,23 @@
 The "Goto procedure definition" functionality may not find procedures referenced using a relative namespace like `$this~tests~procedure()`.
+
+###Analysis:
+(*Describe, what's the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you've changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+
+###Documentation:
+* [ ] ChangesLog updated
+* [ ] Code changes commented
+* **Documentation articles:**

+    * [ ] corresponding documentation articles updated
+    * [ ] new documentation articles created
+    * [ ] not needed
+* **Language files:**
+    * [ ] corresponding language files updated
+    * [ ] not needed
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2021-06-20
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,7 +1,11 @@
 The "Goto procedure definition" functionality may not find procedures referenced using a relative namespace like `$this~tests~procedure()`.

 ###Analysis:
-(*Describe, what's the issue and which changes have to be made*)
+As in the similiar, previous issue, the following lines are missing in `NumeReEditor::FindAndOpenProcedure()`:
+

+    :::c++
+    while (pathname.find('~') != string::npos)
+           pathname[pathname.find('~')] = '\\';

 ###Implementation:

 * Implementation: (*Describe, what you've changed*)
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2021-06-20
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -8,20 +8,20 @@
            pathname[pathname.find('~')] = '\\';

 ###Implementation:
-* Implementation: (*Describe, what you've changed*) 
-* Revision: [rXXX]
-* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+* Implementation: The fix was implemented as proposed by the analysis.
+* Revision: [r902]
+* Implementation test: Functionality was tested using the usual shortcuts.

 ###Documentation:
-* [ ] ChangesLog updated
-* [ ] Code changes commented
+* [x] ChangesLog updated
+* [x] Code changes commented

 * **Documentation articles:**
     * [ ] corresponding documentation articles updated
     * [ ] new documentation articles created
-    * [ ] not needed
+    * [x] not needed
 * **Language files:**
     * [ ] corresponding language files updated
-    * [ ] not needed
+    * [x] not needed

 ###Tests:
 (*Describe, which tests you performed and their outcome*)
    • status: implementing --> testing
     

    Related

    Commit: [r902]

  • Erik Hänel

    Erik Hänel - 2021-07-14
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -24,4 +24,4 @@

     * [x] not needed

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+Fix was tested manually. No deviation occured.
    • status: testing --> fixed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB