Menu ▾ ▴

#571 Block autocompletion

v1.1.x
closed
Erik Hänel
None
v1.1.3
New Functionality
2021-07-16
2021-04-09
Erik Hänel
No

NumeRe features parenthesis autocompletion, but it does not autocomplete blocks.

Analysis:

This feature needs a hook into the autocompletion feature as it does not make sense to hook it into the OnKeyDown event (due to the command ifndef, which would erroneously autocomplete to 

if (ndef)
endif

if the user would keep on typing without recognizing. If we introduce the hook into the autocompletion feature, we can also modify the creation of parentheses after functions and procedures (avoid, if not needed, otherwise autocomplete).

Implementation:

  • Implementation: The feature was implemented as proposed by the analysis.
  • Revision: [r861]
  • Implementation test: Different scenarios were tested with the new block autocompletion feature.

Documentation:

  • [x] ChangesLog updated
  • [x] Code changes commented
  • Documentation articles:
    • [ ] corresponding documentation articles updated
    • [ ] new documentation articles created
    • [x] not needed
  • Language files:
    • [ ] corresponding language files updated
    • [x] not needed

Tests:

Improved implementation with [r918]. No further deviation detected.

Related

Commit: [r861]
Commit: [r918]

Discussion

  • Erik Hänel

    Erik Hänel - 2021-04-09
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2021-04-25
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,23 @@
 NumeRe features parenthesis autocompletion, but it does not autocomplete blocks.
+
+###Analysis:
+(*Describe, what's the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you've changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+
+###Documentation:
+* [ ] ChangesLog updated
+* [ ] Code changes commented
+* **Documentation articles:**

+    * [ ] corresponding documentation articles updated
+    * [ ] new documentation articles created
+    * [ ] not needed
+* **Language files:**
+    * [ ] corresponding language files updated
+    * [ ] not needed
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2021-04-26
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,7 +1,12 @@
 NumeRe features parenthesis autocompletion, but it does not autocomplete blocks.

 ###Analysis:
-(*Describe, what's the issue and which changes have to be made*)
+This feature needs a hook into the autocompletion feature as it does not make sense to hook it into the `OnKeyDown` event (due to the command `ifndef`, which would erroneously autocomplete to 
+

+    if (ndef)
+    endif
+    
+if the user would keep on typing without recognizing. If we introduce the hook into the autocompletion feature, we can also modify the creation of parentheses after functions and procedures (avoid, if not needed, otherwise autocomplete).

 ###Implementation:

 * Implementation: (*Describe, what you've changed*)
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2021-04-26
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -9,20 +9,20 @@
 if the user would keep on typing without recognizing. If we introduce the hook into the autocompletion feature, we can also modify the creation of parentheses after functions and procedures (avoid, if not needed, otherwise autocomplete).

 ###Implementation:
-* Implementation: (*Describe, what you've changed*) 
-* Revision: [rXXX]
-* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+* Implementation: The feature was implemented as proposed by the analysis.
+* Revision: [r861]
+* Implementation test: Different scenarios were tested with the new block autocompletion feature.

 ###Documentation:
-* [ ] ChangesLog updated
-* [ ] Code changes commented
+* [x] ChangesLog updated
+* [x] Code changes commented

 * **Documentation articles:**
     * [ ] corresponding documentation articles updated
     * [ ] new documentation articles created
-    * [ ] not needed
+    * [x] not needed
 * **Language files:**
     * [ ] corresponding language files updated
-    * [ ] not needed
+    * [x] not needed

 ###Tests:
 (*Describe, which tests you performed and their outcome*)
    • status: implementing --> testing
     

    Related

    Commit: [r861]

  • Erik Hänel

    Erik Hänel - 2021-07-16
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -25,4 +25,4 @@

     * [x] not needed

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+Improved implementation with [r918]. No further deviation detected.
    • status: testing --> closed
     

    Related

    Commit: [r918]

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB