Menu ▾ ▴

#564 Extend 'totable' option

v1.1.x
closed
Erik Hänel
None
v1.1.3
Change Request
2021-03-22
2021-02-22
Erik Hänel
No

The totable option provides the possibility to load some data directly to the table referenced by the file or the filename (if not a NDAT file). In the procedure case it might be necessary to store a file locally, therefore it is reasonable to extend the totable option to accept a target table: totable=TARGET().

Analysis:

Perform these steps:

  • Create a specialized reader function for the enhanced totable=TABLE() option
  • Add an optional argument to FileHeaderInfo FileAdapter::openFile(std::string, bool, int) with the type const std::string& sTargetTable = "", which will use the passed name or the automatically created one, if necessary
  • Add the new optional argument to the reasonable locations in static CommandReturnValues cmd_load(string& sCmd)

Implementation:

  • Implementation: Implemented as described by the analysis.
  • Revision: [r835]
  • Implementation test: The totable option was used with and without an argument in single and multiple data file case (option all).

Documentation:

  • [x] ChangesLog updated
  • [x] Code changes commented
  • Documentation articles:
    • [x] corresponding documentation articles updated
    • [ ] new documentation articles created
    • [ ] not needed
  • Language files:
    • [ ] corresponding language files updated
    • [x] not needed

Tests:

Added to the SW tests. Tests run without any deviation.

Related

Commit: [r835]

Discussion

  • Erik Hänel

    Erik Hänel - 2021-02-22
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1 @@
-The `totable` option provides the possibility to load some data directly to the table referenced by the file or the filename (if not a NDAT file). In the procedure case it might be necessary to store a file locally, therefore it is reasonable to extend the `totable` option to accept a target table: `totable=TARGEt()`.
+The `totable` option provides the possibility to load some data directly to the table referenced by the file or the filename (if not a NDAT file). In the procedure case it might be necessary to store a file locally, therefore it is reasonable to extend the `totable` option to accept a target table: `totable=TARGET()`.
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2021-02-23
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,23 @@
 The `totable` option provides the possibility to load some data directly to the table referenced by the file or the filename (if not a NDAT file). In the procedure case it might be necessary to store a file locally, therefore it is reasonable to extend the `totable` option to accept a target table: `totable=TARGET()`.
+
+###Analysis:
+(*Describe, what's the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you've changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+
+###Documentation:
+* [ ] ChangesLog updated
+* [ ] Code changes commented
+* **Documentation articles:**

+    * [ ] corresponding documentation articles updated
+    * [ ] new documentation articles created
+    * [ ] not needed
+* **Language files:**
+    * [ ] corresponding language files updated
+    * [ ] not needed
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2021-02-23
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,7 +1,11 @@
 The `totable` option provides the possibility to load some data directly to the table referenced by the file or the filename (if not a NDAT file). In the procedure case it might be necessary to store a file locally, therefore it is reasonable to extend the `totable` option to accept a target table: `totable=TARGET()`.

 ###Analysis:
-(*Describe, what's the issue and which changes have to be made*)
+Perform these steps:
+
+* Create a specialized reader function for the enhanced `totable=TABLE()` option
+* Add an optional argument to `FileHeaderInfo FileAdapter::openFile(std::string, bool, int)` with the type `const std::string& sTargetTable = ""`, which will use the passed name or the automatically created one, if necessary
+* Add the new optional argument to the reasonable locations in `static CommandReturnValues cmd_load(string& sCmd)`

 ###Implementation:

 * Implementation: (*Describe, what you've changed*)
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2021-02-23
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -8,20 +8,20 @@

 * Add the new optional argument to the reasonable locations in `static CommandReturnValues cmd_load(string& sCmd)`

 ###Implementation:
-* Implementation: (*Describe, what you've changed*) 
-* Revision: [rXXX]
-* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+* Implementation: Implemented as described by the analysis.
+* Revision: [r835]
+* Implementation test: The `totable` option was used with and without an argument in single and multiple data file case (option `all`).

 ###Documentation:
-* [ ] ChangesLog updated
-* [ ] Code changes commented
+* [x] ChangesLog updated
+* [x] Code changes commented

 * **Documentation articles:**
-    * [ ] corresponding documentation articles updated
+    * [x] corresponding documentation articles updated
     * [ ] new documentation articles created
     * [ ] not needed
 * **Language files:**
     * [ ] corresponding language files updated
-    * [ ] not needed
+    * [x] not needed

 ###Tests:
 (*Describe, which tests you performed and their outcome*)
    • status: implementing --> testing
     

    Related

    Commit: [r835]

  • Erik Hänel

    Erik Hänel - 2021-03-22
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -24,4 +24,4 @@

     * [x] not needed

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+Added to the SW tests. Tests run without any deviation.
    • status: testing --> closed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB