Menu ▾ ▴

#545 Improve ESC key behavior

v1.1.x
closed
Erik Hänel
None
v1.1.3
Change Request
2021-03-22
2020-11-17
Erik Hänel
No

Improve the behavior of the ESC key to avoid erroneous cancelations of calculations. This can probably be implemented by removing the direct access to the Windows key states and instead adding a key event handler to the terminal. This will ensure that the ESC key is only forwarded, if the terminal has keyboard focus.

Analysis:

The content of the description indicates a good possibility by using the key event handler of the terminal.

Implementation:

  • Implementation: The implementation was processed as indicated by the analysis.
  • Revision: [r796]
  • Implementation test: A script was started, the ESC key was tested in different scenarios. The calculation was only aborted, if the terminal had keyboard focus.

Documentation:

  • [x] ChangesLog updated
  • [x] Code changes commented
  • Documentation articles:
    • [ ] corresponding documentation articles updated
    • [ ] new documentation articles created
    • [x] not needed
  • Language files:
    • [ ] corresponding language files updated
    • [x] not needed

Tests:

Manual test.

Related

Commit: [r796]

Discussion

  • Erik Hänel

    Erik Hänel - 2020-11-19
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2020-11-19
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,23 @@
 Improve the behavior of the `ESC` key to avoid erroneous cancelations of calculations. This can probably be implemented by removing the direct access to the Windows key states and instead adding a key event handler to the terminal. This will ensure that the `ESC` key is only forwarded, if the terminal has keyboard focus.
+
+###Analysis:
+(*Describe, what's the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you've changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+
+###Documentation:
+* [ ] ChangesLog updated
+* [ ] Code changes commented
+* **Documentation articles:**

+    * [ ] corresponding documentation articles updated
+    * [ ] new documentation articles created
+    * [ ] not needed
+* **Language files:**
+    * [ ] corresponding language files updated
+    * [ ] not needed
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2020-11-19
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,7 +1,7 @@
 Improve the behavior of the `ESC` key to avoid erroneous cancelations of calculations. This can probably be implemented by removing the direct access to the Windows key states and instead adding a key event handler to the terminal. This will ensure that the `ESC` key is only forwarded, if the terminal has keyboard focus.

 ###Analysis:
-(*Describe, what's the issue and which changes have to be made*)
+The content of the description indicates a good possibility by using the key event handler of the terminal.

 ###Implementation:

 * Implementation: (*Describe, what you've changed*)
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2020-11-19
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -4,20 +4,20 @@
 The content of the description indicates a good possibility by using the key event handler of the terminal.

 ###Implementation:
-* Implementation: (*Describe, what you've changed*) 
-* Revision: [rXXX]
-* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+* Implementation: The implementation was processed as indicated by the analysis.
+* Revision: [r796]
+* Implementation test: A script was started, the ESC key was tested in different scenarios. The calculation was only aborted, if the terminal had keyboard focus.

 ###Documentation:
-* [ ] ChangesLog updated
-* [ ] Code changes commented
+* [x] ChangesLog updated
+* [x] Code changes commented

 * **Documentation articles:**
     * [ ] corresponding documentation articles updated
     * [ ] new documentation articles created
-    * [ ] not needed
+    * [x] not needed
 * **Language files:**
     * [ ] corresponding language files updated
-    * [ ] not needed
+    * [x] not needed

 ###Tests:
 (*Describe, which tests you performed and their outcome*)
    • status: implementing --> testing
     

    Related

    Commit: [r796]

  • Erik Hänel

    Erik Hänel - 2021-03-22
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -20,4 +20,4 @@

     * [x] not needed

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+Manual test.
    • status: testing --> closed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB