Menu ▾ ▴

#544 Crash when pressing F2

v1.1.x
fixed
Erik Hänel
None
v1.1.2
Bug Fix
2021-03-23
2020-11-16
Erik Hänel
No

NumeRe crashes, if one presses F2 while the keyboard focus is on the revision dialog.

Analysis:

The issue is inside the wxcode implementation of wxTreeListCtrl, where the keycode gets casted to a const char*, which is obviously absolute bullshit.

Implementation:

  • Implementation: Resolved the issue identified in the analysis.
  • Revision: [r795]
  • Implementation test: Tried multiple keys without any deviation.

Documentation:

  • [x] ChangesLog updated
  • [ ] Code changes commented
  • Documentation articles:
    • [ ] corresponding documentation articles updated
    • [ ] new documentation articles created
    • [x] not needed
  • Language files:
    • [ ] corresponding language files updated
    • [x] not needed

Tests:

Tested with all widgets using the same code base. No deviations occured.

Related

Commit: [r795]

Discussion

  • Erik Hänel

    Erik Hänel - 2020-11-18
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2020-11-18
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,23 @@
 NumeRe crashes, if one presses `F2` while the keyboard focus is on the revision dialog.
+
+###Analysis:
+(*Describe, what's the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you've changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+
+###Documentation:
+* [ ] ChangesLog updated
+* [ ] Code changes commented
+* **Documentation articles:**

+    * [ ] corresponding documentation articles updated
+    * [ ] new documentation articles created
+    * [ ] not needed
+* **Language files:**
+    * [ ] corresponding language files updated
+    * [ ] not needed
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2020-11-18
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,7 +1,7 @@
 NumeRe crashes, if one presses `F2` while the keyboard focus is on the revision dialog.

 ###Analysis:
-(*Describe, what's the issue and which changes have to be made*)
+The issue is inside the `wxcode` implementation of `wxTreeListCtrl`, where the keycode gets casted to a `const char*`, which is obviously absolute bullshit.

 ###Implementation:

 * Implementation: (*Describe, what you've changed*)
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2020-11-18
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -4,20 +4,20 @@
 The issue is inside the `wxcode` implementation of `wxTreeListCtrl`, where the keycode gets casted to a `const char*`, which is obviously absolute bullshit.

 ###Implementation:
-* Implementation: (*Describe, what you've changed*) 
-* Revision: [rXXX]
-* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+* Implementation: Resolved the issue identified in the analysis.
+* Revision: [r795]
+* Implementation test: Tried multiple keys without any deviation.

 ###Documentation:
-* [ ] ChangesLog updated
+* [x] ChangesLog updated

 * [ ] Code changes commented
 * **Documentation articles:**
     * [ ] corresponding documentation articles updated
     * [ ] new documentation articles created
-    * [ ] not needed
+    * [x] not needed
 * **Language files:**
     * [ ] corresponding language files updated
-    * [ ] not needed
+    * [x] not needed

 ###Tests:
 (*Describe, which tests you performed and their outcome*)
    • status: implementing --> testing
     

    Related

    Commit: [r795]

  • Erik Hänel

    Erik Hänel - 2021-03-23
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -20,4 +20,4 @@

     * [x] not needed

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+Tested with all widgets using the same code base. No deviations occured.
    • status: testing --> fixed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB