Menu ▾ ▴

#533 Procedure autocompletion does not work well for local procedures

v1.1.x
fixed
Erik Hänel
None
v1.1.2
Bug Fix
2020-11-02
2020-09-26
Erik Hänel
No

Procedure autocompletion does not work well for local procedures.

Analysis:

The procedures are not found due to two missing ! in 

wxString SearchController::FindProceduresInCurrentFile(wxString, wxString

This is a refactoring regression. Furthermore, namespaces are not presented in the autocompletion list due to the fact that the namespace in procedures defaults to this~ in

wxString SearchController::FindNameSpaceOfProcedure(int)

which is obviously wrong.

Implementation:

  • Implementation: The fix was processed as indicated by the analysis.
  • Revision: [r769]
  • Implementation test: The autocompletion feature was tested manually.

Documentation:

  • [x] ChangesLog updated
  • [ ] Code changes commented
  • Documentation articles:
    • [ ] corresponding documentation articles updated
    • [ ] new documentation articles created
    • [x] not needed
  • Language files:
    • [ ] corresponding language files updated
    • [x] not needed

Tests:

Bug fix was tested manually. No deviations occured.

Related

Commit: [r769]

Discussion

  • Erik Hänel

    Erik Hänel - 2020-09-26
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2020-09-26
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,23 @@
 Procedure autocompletion does not work well for local procedures.
+
+###Analysis:
+(*Describe, what's the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you've changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+
+###Documentation:
+* [ ] ChangesLog updated
+* [ ] Code changes commented
+* **Documentation articles:**

+    * [ ] corresponding documentation articles updated
+    * [ ] new documentation articles created
+    * [ ] not needed
+* **Language files:**
+    * [ ] corresponding language files updated
+    * [ ] not needed
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2020-09-26
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,7 +1,15 @@
 Procedure autocompletion does not work well for local procedures.

 ###Analysis:
-(*Describe, what's the issue and which changes have to be made*)
+The procedures are not found due to two missing `!` in 
+

+    wxString SearchController::FindProceduresInCurrentFile(wxString, wxString 
+
+This is a refactoring regression. Furthermore, namespaces are not presented in the autocompletion list due to the fact that the namespace in procedures defaults to `this~` in
+
+    wxString SearchController::FindNameSpaceOfProcedure(int)
+   
+which is obviously wrong.

 ###Implementation:

 * Implementation: (*Describe, what you've changed*)
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2020-09-26
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -12,20 +12,20 @@
 which is obviously wrong.

 ###Implementation:
-* Implementation: (*Describe, what you've changed*) 
-* Revision: [rXXX]
-* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+* Implementation: The fix was processed as indicated by the analysis.
+* Revision: [r769]
+* Implementation test: The autocompletion feature was tested manually.

 ###Documentation:
-* [ ] ChangesLog updated
+* [x] ChangesLog updated

 * [ ] Code changes commented
 * **Documentation articles:**
     * [ ] corresponding documentation articles updated
     * [ ] new documentation articles created
-    * [ ] not needed
+    * [x] not needed
 * **Language files:**
     * [ ] corresponding language files updated
-    * [ ] not needed
+    * [x] not needed

 ###Tests:
 (*Describe, which tests you performed and their outcome*)
    • status: implementing --> testing
     

    Related

    Commit: [r769]

  • Erik Hänel

    Erik Hänel - 2020-11-02
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -28,4 +28,4 @@

     * [x] not needed

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+Bug fix was tested manually. No deviations occured.
    • status: testing --> fixed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB