Menu ▾ ▴

#53 string() should get a second dimension

v1.0.x
closed
Erik Hänel
None
v1.0.9
Change Request
2016-07-11
2016-06-14
Erik Hänel
No

The string() object should get a second dimension for simpler interaction. The parser should be capable of interpreting both writings:

string(j1:j2)
string(i,j1:j2)

Analysis:
This change requires a total change in interface. Every function capable of acting with the string() object has to be investigated.
Probably the best change is to implement default values just like

STRING_TYPE stringfunc(indices) -> STRING_TYPE stringfunc(indices,col=0)

Implementation:
Change was implemented as proposed by the analysis. Proposed syntax was changed from string(i,j1:j2) to string(i1:i2,j).

Tests:
Tests were passed successfully. Change accepted.

Discussion

  • Erik Hänel

    Erik Hänel - 2016-06-14
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2016-06-16
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -3,3 +3,9 @@
 string(j1:j2)
 string(i,j1:j2)
 ~~~
+
+**Analysis:**
+
+**Implementation:**
+
+**Tests:**
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2016-06-19
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -5,6 +5,11 @@
 ~~~

 **Analysis:**
+This change requires a total change in interface. Every function capable of acting with the `string()` object has to be investigated.
+Probably the best change is to implement default values just like
+~~~C
+STRING_TYPE stringfunc(indices) -> STRING_TYPE stringfunc(indices,col=0)
+~~~

 **Implementation:**
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2016-06-19
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -12,5 +12,6 @@
 ~~~

 **Implementation:**
+Change was implemented as proposed by the analysis. Proposed syntax was changed from `string(i,j1:j2)` to `string(i1:i2,j)`.

 **Tests:**
    • status: implementing --> testing
     

  • Erik Hänel

    Erik Hänel - 2016-07-11
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -15,3 +15,4 @@
 Change was implemented as proposed by the analysis. Proposed syntax was changed from `string(i,j1:j2)` to `string(i1:i2,j)`.

 **Tests:**
+Tests were passed successfully. Change accepted.
    • status: testing --> closed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB