Menu ▾ ▴

#506 Create a command to close all floating windows

v1.1.x
closed
Erik Hänel
None
v1.1.3
New Functionality
2021-03-22
2020-01-22
Erik Hänel
No

Create a command to close all floating windows for situations, in which many plots are created and shall be closed at once.

Analysis:

This can be implemented by processing the following steps:

  • create an enum WindowType, which defines all window types that are closable by a terminal command
  • create a std::map<wxWindow*, WindowType>, where all opened windows are registered
  • Add an unregister functionality to all closable windows, so that they unregister themselves, if they are closed manually
  • Create the command and a new NumeReKernel::KernelStatus type to communicate with the GUI
  • Add the corresponding closing handler

Implementation:

  • Implementation: The implementation was carried out as proposed by the analysis.
  • Revision: [r802]
  • Implementation test: Different combinations of windows were closed using close without deviation.

Documentation:

  • [x] ChangesLog updated
  • [x] Code changes commented
  • Documentation articles:
    • [x] corresponding documentation articles updated
    • [ ] new documentation articles created
    • [ ] not needed
  • Language files:
    • [x] corresponding language files updated
    • [ ] not needed

Tests:

Manual test.

Related

Commit: [r802]

Discussion

  • Erik Hänel

    Erik Hänel - 2020-11-15
    • status: open --> accepted
    • Version: Planned --> v1.1.3
     

  • Erik Hänel

    Erik Hänel - 2020-11-30
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,23 @@
 Create a command to close all floating windows for situations, in which many plots are created and shall be closed at once.
+
+###Analysis:
+(*Describe, what&#39;s the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you&#39;ve changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+
+###Documentation:
+* [ ] ChangesLog updated
+* [ ] Code changes commented
+* **Documentation articles:**

+    * [ ] corresponding documentation articles updated
+    * [ ] new documentation articles created
+    * [ ] not needed
+* **Language files:**
+    * [ ] corresponding language files updated
+    * [ ] not needed
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2020-12-02
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,7 +1,13 @@
 Create a command to close all floating windows for situations, in which many plots are created and shall be closed at once.

 ###Analysis:
-(*Describe, what&#39;s the issue and which changes have to be made*)
+This can be implemented by processing the following steps: 
+
+* create an `enum WindowType`, which defines all window types that are closable by a terminal command
+* create a `std::map&lt;wxWindow*, WindowType&gt;`, where all opened windows are registered
+* Add an unregister functionality to all closable windows, so that they unregister themselves, if they are closed manually
+* Create the command and a new `NumeReKernel::KernelStatus` type to communicate with the GUI
+* Add the corresponding closing handler

 ###Implementation:

 * Implementation: (*Describe, what you&#39;ve changed*)
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2020-12-02
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -10,19 +10,19 @@

 * Add the corresponding closing handler

 ###Implementation:
-* Implementation: (*Describe, what you&#39;ve changed*) 
-* Revision: [rXXX]
-* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+* Implementation: The implementation was carried out as proposed by the analysis.
+* Revision: [r802]
+* Implementation test: Different combinations of windows were closed using `close` without deviation.

 ###Documentation:
-* [ ] ChangesLog updated
-* [ ] Code changes commented
+* [x] ChangesLog updated
+* [x] Code changes commented

 * **Documentation articles:**
-    * [ ] corresponding documentation articles updated
+    * [x] corresponding documentation articles updated
     * [ ] new documentation articles created
     * [ ] not needed
 * **Language files:**
-    * [ ] corresponding language files updated
+    * [x] corresponding language files updated
     * [ ] not needed

 ###Tests:
    • status: implementing --> testing
     

    Related

    Commit: [r802]

  • Erik Hänel

    Erik Hänel - 2021-03-22
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -26,4 +26,4 @@

     * [ ] not needed

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+Manual test.
    • status: testing --> closed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB