Menu ▾ ▴

#504 'datagrid' does not use the dimension of passed index vectors

v1.1.x
fixed
Erik Hänel
None
v1.1.1
Bug Fix
2020-03-31
2020-01-21
Erik Hänel
No

The command datagrid does not copy the dimensions determined by a dataset, which was used as one of the both axes.

Analysis:

The issue is that the new static function

static vector<double> extractVectorForDatagrid(..., ..., ..., size_t nSamples, ..., ..., ...)

is not allowed to change the passed samples due to the size of the data set. Allowing this function to alter this value via size_t& nSamples, will solve the problem.

Implementation:

  • Implementation: The fix was processed as proposed by the analysis.
  • Revision: [r679]
  • Implementation test: A data grid was created usind data sets as axis definitions.

Documentation:

  • [x] ChangesLog updated
  • [x] Code changes commented
  • Documentation articles:
    • [ ] corresponding documentation articles updated
    • [ ] new documentation articles created
    • [x] not needed
  • Language files:
    • [ ] corresponding language files updated
    • [x] not needed

Tests:

This fix was tested in productive environment. No deviations detected. Bug fix implemented successfully.

Related

Commit: [r679]

Discussion

  • Erik Hänel

    Erik Hänel - 2020-01-21
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2020-01-21
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,23 @@
 The command `datagrid` does not copy the dimensions determined by a dataset, which was used as one of the both axes.
+
+###Analysis:
+(*Describe, what&#39;s the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you&#39;ve changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+
+###Documentation:
+* [ ] ChangesLog updated
+* [ ] Code changes commented
+* **Documentation articles:**

+    * [ ] corresponding documentation articles updated
+    * [ ] new documentation articles created
+    * [ ] not needed
+* **Language files:**
+    * [ ] corresponding language files updated
+    * [ ] not needed
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2020-01-21
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,7 +1,12 @@
 The command `datagrid` does not copy the dimensions determined by a dataset, which was used as one of the both axes.

 ###Analysis:
-(*Describe, what&#39;s the issue and which changes have to be made*)
+The issue is that the new static function
+

+    :::C++
+    static vector&lt;double&gt; extractVectorForDatagrid(..., ..., ..., size_t nSamples, ..., ..., ...)
+    
+is not allowed to change the passed samples due to the size of the data set. Allowing this function to alter this value via `size_t&amp; nSamples`, will solve the problem.

 ###Implementation:

 * Implementation: (*Describe, what you&#39;ve changed*)
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2020-01-21
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -9,20 +9,20 @@
 is not allowed to change the passed samples due to the size of the data set. Allowing this function to alter this value via `size_t&amp; nSamples`, will solve the problem.

 ###Implementation:
-* Implementation: (*Describe, what you&#39;ve changed*) 
-* Revision: [rXXX]
-* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+* Implementation: The fix was processed as proposed by the analysis.
+* Revision: [r679]
+* Implementation test: A data grid was created usind data sets as axis definitions.

 ###Documentation:
-* [ ] ChangesLog updated
-* [ ] Code changes commented
+* [x] ChangesLog updated
+* [x] Code changes commented

 * **Documentation articles:**
     * [ ] corresponding documentation articles updated
     * [ ] new documentation articles created
-    * [ ] not needed
+    * [x] not needed
 * **Language files:**
     * [ ] corresponding language files updated
-    * [ ] not needed
+    * [x] not needed

 ###Tests:
 (*Describe, which tests you performed and their outcome*)
    • status: implementing --> testing
     

    Related

    Commit: [r679]

  • Erik Hänel

    Erik Hänel - 2020-03-31
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -25,4 +25,4 @@

     * [x] not needed

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+This fix was tested in productive environment. No deviations detected. Bug fix implemented successfully.
    • status: testing --> fixed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB