Menu ▾ ▴

#502 Usage of string expressions in local variable declaration not possible

v1.1.x
fixed
Erik Hänel
None
v1.1.2
Bug Fix
2020-03-31
2020-01-11
Erik Hänel
No

Usage of string expressions in local variable declaration is not possible, if the current variable is the last in the line of declarations.

Analysis:

The issue is that in ProcedureVarFactory::createLocalVars the wrong variable is used for the string expression. Currently, the variable sVarList is used, but it should be sVarValue.

Implementation:

  • Implementation: The fix was applied as indicated by the analysis.
  • Revision: [r667]
  • Implementation test: The erroneous code was re-executed without any deviation.

Documentation:

  • [x] ChangesLog updated
  • [x] Code changes commented
  • Documentation articles:
    • [ ] corresponding documentation articles updated
    • [ ] new documentation articles created
    • [x] not needed
  • Language files:
    • [ ] corresponding language files updated
    • [x] not needed

Tests:

This fix was tested in productive environment. No deviations detected. Bug fix implemented successfully.

Related

Commit: [r667]

Discussion

  • Erik Hänel

    Erik Hänel - 2020-01-11
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2020-01-11
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,23 @@
 Usage of string expressions in local variable declaration is not possible, if the current variable is the last in the line of declarations.
+
+###Analysis:
+(*Describe, what's the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you've changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+
+###Documentation:
+* [ ] ChangesLog updated
+* [ ] Code changes commented
+* **Documentation articles:**

+    * [ ] corresponding documentation articles updated
+    * [ ] new documentation articles created
+    * [ ] not needed
+* **Language files:**
+    * [ ] corresponding language files updated
+    * [ ] not needed
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2020-01-11
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,7 +1,7 @@
 Usage of string expressions in local variable declaration is not possible, if the current variable is the last in the line of declarations.

 ###Analysis:
-(*Describe, what's the issue and which changes have to be made*)
+The issue is that in `ProcedureVarFactory::createLocalVars` the wrong variable is used for the string expression. Currently, the variable `sVarList` is used, but it should be `sVarValue`.

 ###Implementation:

 * Implementation: (*Describe, what you've changed*)
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2020-01-11
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -4,20 +4,20 @@
 The issue is that in `ProcedureVarFactory::createLocalVars` the wrong variable is used for the string expression. Currently, the variable `sVarList` is used, but it should be `sVarValue`.

 ###Implementation:
-* Implementation: (*Describe, what you've changed*) 
-* Revision: [rXXX]
-* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+* Implementation: The fix was applied as indicated by the analysis.
+* Revision: [r667]
+* Implementation test: The erroneous code was re-executed without any deviation.

 ###Documentation:
-* [ ] ChangesLog updated
-* [ ] Code changes commented
+* [x] ChangesLog updated
+* [x] Code changes commented

 * **Documentation articles:**
     * [ ] corresponding documentation articles updated
     * [ ] new documentation articles created
-    * [ ] not needed
+    * [x] not needed
 * **Language files:**
     * [ ] corresponding language files updated
-    * [ ] not needed
+    * [x] not needed

 ###Tests:
 (*Describe, which tests you performed and their outcome*)
    • status: implementing --> testing
     

    Related

    Commit: [r667]

  • Erik Hänel

    Erik Hänel - 2020-03-31
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -20,4 +20,4 @@

     * [x] not needed

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+This fix was tested in productive environment. No deviations detected. Bug fix implemented successfully.
    • status: testing --> fixed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB